-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change fill to white to match other icons. #971
Conversation
Fixes nextcloud#703 Signed-off-by: Andrew Hunter <andrew@hunter.camera>
The dark icon would still be needed, so maybe you can put it as circles-dark.svg and make sure that it is used in the places where the current one was used before: lib/Notification/Notifier.php lib/Activity/Filter.php lib/UnifiedSearch/UnifiedSearchProvider.php lib/Model/ShareWrapper.php |
@juliushaertl Hi! A separate icon for a dark theme is not required; the dark theme expects a pure white filled icon which it then styles: This behavior is consistent with other 1st party apps in Nextcloud. |
It is not about the dark theme but other places where the icon is used like notifications or activity. There a dark icon variant would still be required. |
Done in another PR |
Fixes #703