Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ReferenceProvider): Check pathinfo return value before using it #1169

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Mar 20, 2024

Fixes: #1167

Fixes: #1167

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- force-pushed the fix/reference_provider_fileinfo branch from e77e3d5 to d4235cc Compare March 21, 2024 10:55
Copy link

cypress bot commented Mar 21, 2024

21 failed and 3 flaky tests on run #1465 ↗︎

21 184 0 4 Flakiness 3

Details:

fix(ReferenceProvider): Check `pathinfo` return value before using it
Project: Collectives Commit: d4235cc650
Status: Failed Duration: 47:18 💡
Started: Mar 22, 2024 3:22 PM Ended: Mar 22, 2024 4:10 PM
Failed  pages-links.spec.js • 19 failed tests • Nextcloud master

View Output

Test Artifacts
Page link handling > Link handling to viewer in view mode > Opens link with absolute path to image in Nextcloud in viewer Screenshots
Page link handling > Link handling to viewer in view mode > Opens link with absolute path to text file in Nextcloud in viewer Screenshots
Page link handling > Link handling to viewer in edit mode > Opens link with absolute path to image in Nextcloud in viewer Screenshots
Page link handling > Link handling to viewer in edit mode > Opens link with absolute path to text file in Nextcloud in viewer Screenshots
Page link handling > Link handling to viewer in edit mode > Opens link with relative path to pdf in Nextcloud in viewer Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with absolute path to page in this collective in same tab Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with relative path to markdown file in this collective without fileId in same tag Screenshots
Page link handling > Link handling to collectives in edit mode > Opens link with URL to page in this collective in same tab Screenshots
Page link handling > Link handling to collectives in edit mode > Opens link with absolute path to page in this collective in same tab Screenshots
Page link handling > Link handling to collectives in edit mode > Opens link with relative path to page in this collective with fileId in same tab Screenshots
The first 10 failed tests are shown, see all 19 tests in Cypress Cloud.
Failed  page-list.spec.js • 1 failed test • Nextcloud stable27

View Output

Test Artifacts
Page list > Page trash > allows to trash and restore page with subpage and attachment Screenshots
Failed  page-share.spec.js • 1 failed test • Nextcloud stable27

View Output

Test Artifacts
Page share > page share > Allows sharing a page Screenshots
Flakiness  pages-links.spec.js • 2 flaky tests • Nextcloud master

View Output

Test Artifacts
Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective with fileId and outdated path in same tab Screenshots
Page link handling > Link handling to collectives in view mode > Opens link with relative path to page in this collective without fileId in same tab Screenshots
Flakiness  page-details.spec.js • 1 flaky test • Nextcloud stable27

View Output

Test Artifacts
Page details > Display table of contents > Allows to display/close TOC and switch page modes in between Screenshots

Review all test suite changes for PR #1169 ↗︎

@mejo- mejo- merged commit d75724f into main Mar 25, 2024
48 of 53 checks passed
@mejo- mejo- deleted the fix/reference_provider_fileinfo branch March 25, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Undefined array key in SearchablePageReferenceProvider
2 participants