-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't show groups in share placeholder if group sharing is disabled #2242
Comments
Hello! I would like to work on this issue, is it available? If so, can you tell more about this ? |
Great ! So in server we have introduced nextcloud/server#25658 a while ago, which is a flag to disable sharing with groups. It's working as intended, no groups are suggested in the autocomplete sharing field, but it would be nicer if the placeholder just said To know if group sharing if enabled you'll have to get the config value here and provide it though initial state. $this->config->getAppValue('core', 'shareapi_allow_group_sharing', 'yes') === 'yes' https://github.com/nextcloud/contacts/blob/master/lib/Controller/PageController.php Then you can get the state for instance in a service: And finally change the placeholder in the component linked at first depending on this value. |
Awesome, thanks! Will come up with updates soon. |
…bled nextcloud#2242 Signed-off-by: Zishan-7 <zishan2539@gmail.com>
…bled nextcloud#2242 Signed-off-by: Zishan-7 <zishan2539@gmail.com>
Hey! I tried to fix the issue can you please review the PR? |
nextcloud#2242 Signed-off-by: Zishan-7 <zishan2539@gmail.com>
nextcloud#2242 Signed-off-by: Zishan-7 <zishan2539@gmail.com>
nextcloud#2242 Signed-off-by: Zishan-7 <zishan2539@gmail.com>
Fix Don't show groups in share placeholder if group sharing is disabled #2242
Steps to reproduce
Expected behaviour
No mention of "groups" in the placeholder.
Actual behaviour
Mention of "groups" in the placeholder.
The text was updated successfully, but these errors were encountered: