Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cy): initial cypress tests #197

Merged
merged 12 commits into from
Jan 11, 2024
Merged

test(cy): initial cypress tests #197

merged 12 commits into from
Jan 11, 2024

Conversation

max-nextcloud
Copy link
Collaborator

@max-nextcloud max-nextcloud commented Jan 3, 2024

Signed-off-by: Max max@nextcloud.com

☑️ Todo

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
We do not need it and it takes quite a while to clone.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
This has the required docker support.

Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Signed-off-by: Max <max@nextcloud.com>
Comment on lines 1 to 5
{
"name": "Using fixtures to represent data",
"email": "hello@cypress.io",
"body": "Fixtures are a great way to mock data for responses to routes"
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{
"name": "Using fixtures to represent data",
"email": "hello@cypress.io",
"body": "Fixtures are a great way to mock data for responses to routes"
}

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and clean!
Any reason you didn't went for typescript straight away?

@max-nextcloud
Copy link
Collaborator Author

Any reason you didn't went for typescript straight away?

Well nothing in particular. I don't feel confident enough with typescript yet and wanted to take time to actually learn the things that i don't know while I encounter them. So I postponed that for a separate PR.

Signed-off-by: Max <max@nextcloud.com>
@max-nextcloud max-nextcloud merged commit 2b603a1 into master Jan 11, 2024
34 checks passed
@delete-merged-branch delete-merged-branch bot deleted the test/cypress branch January 11, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants