Don't run connection wizard when quitting the application #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
|
Hi @sryze , thanks a lot for reporting this and contributing! Will review in a bit |
DominiqueFuchs
suggested changes
Oct 8, 2019
There was a problem hiding this comment.
I added some remarks / discussion points. Maybe @misch7 or @camilasan find the time to throw in their opinion. Thanks again! :-)
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
DominiqueFuchs
approved these changes
Oct 9, 2019
misch7
approved these changes
Oct 16, 2019
misch7
modified the milestones:
2.7 🌟 UI improvements,
2.6.1 🐛 Bug fixes and minor improvements
|
/backport to stable-2.6 |
|
The backport to stable-2.6 failed. Please do this backport manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: When you quit Nextcloud it shows the "New connection" wizard briefly before exit every time.
I nailed it down to the
accountRemovedsignal ofAccountManagerwhich is handled inApplication::slotAccountStateRemoved(). That handler runs the connection wizard when there are no accounts left. Because all the accounts are removed fromAccountManagerduring application shutdown, this event gets triggered at that time.As a "fix" I added a new flag
_isQuittingto the Application class that is set in theaboutToQuithandler (slotCleanup). This is probably a little ugly and there might be a better way to do it, e.g. remove the signal handler foraccountRemovedinstead of setting a flag, but I'm not 100% sure this would not break something, so I chose a safer route 😃