-
Notifications
You must be signed in to change notification settings - Fork 793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run connection wizard when quitting the application #1478
Conversation
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
Hi @sryze , thanks a lot for reporting this and contributing! Will review in a bit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added some remarks / discussion points. Maybe @misch7 or @camilasan find the time to throw in their opinion. Thanks again! :-)
Signed-off-by: Sergey Zolotarev <sryze@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very good catch, thanks! 🎉
One problem less on our list :-)
/backport to stable-2.6 |
The backport to stable-2.6 failed. Please do this backport manually. |
Problem: When you quit Nextcloud it shows the "New connection" wizard briefly before exit every time.
I nailed it down to the
accountRemoved
signal ofAccountManager
which is handled inApplication::slotAccountStateRemoved()
. That handler runs the connection wizard when there are no accounts left. Because all the accounts are removed fromAccountManager
during application shutdown, this event gets triggered at that time.As a "fix" I added a new flag
_isQuitting
to the Application class that is set in theaboutToQuit
handler (slotCleanup
). This is probably a little ugly and there might be a better way to do it, e.g. remove the signal handler foraccountRemoved
instead of setting a flag, but I'm not 100% sure this would not break something, so I chose a safer route 😃