-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not modify discovered files on disk if not necessary #5872
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Too early for approval, @claucambra kindly check failing test, and do not forget to squash commits, then I can approve, thx
Fixed now, feel free to re-review @allexzander |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is missing an update in automated tests to justify and explain the changes
Added a test now |
c8d7a42
to
dd0faff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
dd0faff
to
6bf704c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy
found issue(s) with the introduced code (1/1)
6bf704c
to
270794e
Compare
No clang-tidy warnings found so I assume my comments were addressed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@claucambra Kindly check why SyncCfApiTest (Failed) is failing
270794e
to
23f53cf
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #5872 +/- ##
==========================================
+ Coverage 60.06% 60.11% +0.04%
==========================================
Files 145 145
Lines 18797 18801 +4
==========================================
+ Hits 11291 11302 +11
+ Misses 7506 7499 -7
|
…tmodtime check Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
… permission change was actually made or not Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
… on downsynced file Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…SyncEngine::slotItemDiscovered Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…rnal modtime Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
…pload to server Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
e383140
to
812e696
Compare
AppImage file: nextcloud-PR-5872-812e696d53ef14c326e2312d7007ff40a3d23b3b-x86_64.AppImage |
SonarCloud Quality Gate failed. 0 Bugs 100.0% Coverage The version of Java (11.0.14.1) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
/backport to stable-3.9 |
This prevents the file metadata changing when it doesn't have to, causing conflicts in certain user applications
Close #5842