-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update stable to 20.0.7 #1393
Update stable to 20.0.7 #1393
Conversation
I guess it needs to pass the tests and someone has to merge it. Also waiting for that myself. Edit: on closer inspection there seems to be an issue with the sign-off, does this make sense to you; |
Signed-off-by: Gabriel Augendre <gabriel@augendre.info>
I fixed the DCO check, but for the other failing I don't know what to do 😕 |
I tried to pr a signed commit as well before this started running and still got same (and additional) errors. Could it be that there is some more general issue with the version or that we should run some update script? |
Why is nextcloud incapable of pushing their newest releases to official docker in a timely manner? Almost 3 days have passed ?! |
Yeah that’s why I searched for how to do this here 😕 |
Relax. I am sure they care - but it might take a few days. |
Haha sorry for the harsh tone I'll try to rephrase: It makes me feel like docker is a second-class citizen in the landscape of Nextcloud deployments methods. |
Maybe it is :-) I dunno what is the most common "way" of hosting NC in general, but maybe not Docker? I mean, I can understand if Nextcloud is focusing on the platform used by their enterprise customers. |
Far more than 10M+ pulls imply a huge amount of instances using docker. And "focusing" on their enterprise customers may be the case, but in my opinion that is no excuse to not keep their docker images up to date in a timely manner - updating it literally costs less than 5 minutes !!! (Change version in .sh, commit to git, generate new file for docker-repository, open PR at docker library git, done). |
It could (should?) even be automated and cost nothing :) |
What I don’t get is that errors come from other versions, not 20.0.7. And still it blocks the PR. Edit: maybe it’s just for information, and does not prevent the merge. |
Is it possible to rerun the deployment? The errors that appeared on the two consecutive runs were very inconsistent and the builds had an 1 day gap, with no actual changes in the codebase i believe. So maybe I was thinking there might have been an issue with the pipeline. |
FWIW it has shown to work most reliably, hence https://docs.nextcloud.com/server/latest/admin_manual/installation/source_installation.html describes a classic LAMP setup. While I agree that a delay on this deployment method is very unfortunate I don't see in which why the server team is blocking this? What's different to the 20.0.6? The change set is minimal: https://nextcloud.com/changelog/#latest20. |
I've restarted the checks. Let's see ✌️ |
The nextcloud-cli-mysql service seems to be the issue. And I see it failing on tests performed for other, older versions, unless i misunderstand something. And it's behavior is not consistent throughout the deployments. Is there any way to monitor this besides manual reruns? |
Someone could add more debug statements to the test scripts. The relevant test scripts contains The container could also take too long to start. From my understanding the test script for [1] https://github.com/docker-library/official-images/blob/master/test/tests/nextcloud-cli-mysql/run.sh |
Sorry for the delay, I'll take care in a minute. The issue with the stable tag and why it's not automated is mentioned here: nextcloud-releases/updater_server#68. TL;DR we can easily monitor and automate releases and tags, but not channels like stable or production. |
While the 20.0.7-* tags are online now, the 20 tag is still out of date on docker hub. |
It seems that amd64 images are actually missing... |
20.0.7 still missing, tried just now |
It's there but not for the AMD64 arch it seems. |
yep, tag there but image missing, i have 20.0.6, downloaded and ran, still 20.0.6 :) |
The image is now available for |
Do I need to do something else to generate 20.0.7 images and push them to docker hub ? If no, is there some place I can check the progress ? :)