Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading description: Configuration Parameters / Deleted Items (trash bin) #6889

Closed
SpamReceiver opened this issue Jul 1, 2021 · 2 comments · Fixed by nextcloud/server#33470

Comments

@SpamReceiver
Copy link

https://docs.nextcloud.com/server/stable/admin_manual/configuration_server/config_sample_php_parameters.html#deleted-items-trash-bin

The description of the configuration parameter trashbin_retention_obligation is misleading. There it is described:
"deletes anytime after that if space is needed (note: files may not be deleted if space is not needed)"

However, this is not the implemented behaviour because the question of whether space is needed will only be answered if a user quota is configured.

Hence, the retention of deleted files depends on the user quota setting!

This dependency is not documented. Please update the documentation accordingly.

@isdnfan
Copy link

isdnfan commented Jul 2, 2021

the intention of the affected user from help.nextcloud.com was to enforce file deletion see nextcloud/server#27756
Maybe there should be some value when trashbin removes old files. Personally I feel keeping files in trashbin longer than 2-3 Months (max 6) makes no sense.

@tflidd
Copy link
Contributor

tflidd commented Aug 16, 2021

Personally I feel keeping files in trashbin longer than 2-3 Months (max 6) makes no sense.

Well, can't you set this with the D2 value?

However, this is not the implemented behaviour because the question of whether space is needed will only be answered if a user quota is configured.

so without quota and the auto setting, deleted files will be kept infinitely?
(you can fix the documentation yourself, there is an edit link on top of each page)
It would be great to update the manual to the current behaviour, in a second step we can improve that behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants