feat(deps): Add Nextcloud 30 support #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 tasks
melroy89
reviewed
Jul 2, 2024
appinfo/info.xml
Outdated
| @@ -44,7 +44,7 @@ For this app to be effective, the ClamAV virus definitions should be kept up to | |||
| <screenshot>https://raw.githubusercontent.com/nextcloud/files_antivirus/master/screenshots/1.png</screenshot> | |||
|
|
|||
| <dependencies> | |||
| <nextcloud min-version="25" max-version="28" /> | |||
| <nextcloud min-version="25" max-version="29" /> | |||
There was a problem hiding this comment.
PR title says Nextcloud 30. Here is max version 29.. Is that on purpose?
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
update-master-version
branch
from
b6ac5f1 to
8b533cb
Compare
melroy89
approved these changes
Aug 15, 2024
|
Whats the status of this PR? |
|
Let me rephrase the question: now that NC 30 is released, when are you planning to merge this PR so we can have AV functionality back in NC? |
I can still enable the plugin in NC30. And it does still seem to work. |
|
Thanks for the release. |
|
Fixed in d713fd0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com