Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ClassificationLabel): convert display name to string when filtering #147

Merged
merged 3 commits into from
Jul 19, 2024
Merged

fix(ClassificationLabel): convert display name to string when filtering #147

merged 3 commits into from
Jul 19, 2024

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Jul 8, 2024 •
edited
Loading

Display name can be numeric -> should be converted to a string

@DorraJaouad
fix(ClassificationLabel): convert display name to string when filtering.
882dadc 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
fix: compile
08c6e79 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad added bug Something isn't working javascript Pull requests that update Javascript code 3. to review labels Jul 8, 2024
@DorraJaouad DorraJaouad requested a review from andrey18106 July 8, 2024 10:40
@DorraJaouad DorraJaouad self-assigned this Jul 8, 2024
andrey18106
andrey18106 approved these changes Jul 19, 2024
View reviewed changes
Copy link
Contributor

@andrey18106 andrey18106 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrey18106
Copy link
Contributor

/compile

@nextcloud-command
chore(assets): Recompile assets
7eb01fa 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@andrey18106 andrey18106 merged commit 204dada into main Jul 19, 2024
20 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/numeric-display-name branch July 29, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey18106 andrey18106 andrey18106 approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
3. to review bug Something isn't working javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DorraJaouad @andrey18106 @nextcloud-command