Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add API parameters to specify the lock type #199

Merged
merged 1 commit into from
Jan 24, 2024
Merged

feat: Add API parameters to specify the lock type #199

merged 1 commit into from
Jan 24, 2024

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Dec 19, 2023 •
edited
Loading

Allow setting other lock types through the WebDAV user lock and OCS API.

  • Double check if this covers the use case
  • Add capability to indicate support for the new API parameter
  • Write documentation

Used by nextcloud/desktop#6347

@juliusknorr juliusknorr force-pushed the enh/api-other-lock-types branch 2 times, most recently from 9357689 to f910cec Compare January 12, 2024 11:53
@juliusknorr juliusknorr added enhancement New feature or request 3. to review labels Jan 19, 2024
@mgallien
Copy link
Contributor

@juliushaertl I tested it successfully by cherrypicking it on top of v27.0.3
done for my support ticket

max-nextcloud
max-nextcloud approved these changes Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@max-nextcloud max-nextcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code makes sense to me. Did not test it though.

@juliusknorr
feat: Add API parameters to specify the lock type
6b7ef02 
Signed-off-by: Julius Härtl <jus@bitgrid.net>

tmp: bump max version

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr force-pushed the enh/api-other-lock-types branch from f910cec to 6b7ef02 Compare January 23, 2024 18:37
@juliusknorr
Copy link
Member Author

/backport to stable28

@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr juliusknorr merged commit 05cc400 into main Jan 24, 2024
28 checks passed
@juliusknorr juliusknorr deleted the enh/api-other-lock-types branch January 24, 2024 17:58
This was referenced Jan 24, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@datenangebot datenangebot Awaiting requested review from datenangebot

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@juliusknorr @mgallien @max-nextcloud