[stable29] fix: Use the user configured UI language for PDFjs instead of browser language #1026 #1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/compile |
szaimen
approved these changes
Aug 29, 2024
… language PDFjs uses the browser language by default, but users should have consistently the Nextcloud defined language. So now we set the PDFjs language to: 1. The Nextcloud configured language if supported 2. The unflavored version if supported (e.g. `de` instead of `de-DE`) 3. Fall back to browser UI language We need 3 because if we set an unsupported lanuage PDFjs will default to English, which is worse than the browser UI language. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/stable29-user-lang
branch
from
a405ea7 to
5878856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDFjs uses the browser language by default, but users should have consistently the Nextcloud defined language. So now we set the PDFjs language to:
deinstead ofde-DE)We need 3 because if we set an unsupported lanuage PDFjs will default to English, which is worse than the browser UI language.