Show forms as read-only if the file is not editable #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the file is not editable it can not be saved back to Nextcloud, so in that case the forms should be shown, but only as read-only. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
delete-merged-branch
bot
deleted the
show-forms-as-read-only-if-the-file-is-not-editable
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #787 and #849
If the file is not editable it can not be saved back to Nextcloud, so in that case the forms should be shown, but only as read-only.
While working on this I realized that it might be possible to move the PDF.js initialization to the PDFView.vue file, but... something for the future :-)
How to test
Result with this pull request
The forms can be viewed, but not edited
Result without this pull request
The forms can be edited, but they can not be saved