-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract buttons from pages so the animation does not affect t… #1005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
commented
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would like to block this since layout change breaks the responsive layout
@marcoambrosini will you be able to work on this? I think the idea was good but if broke the responsive layout |
5682a2c
to
bead0e4
Compare
bead0e4
to
f4cf83e
Compare
f4cf83e
to
00c7aec
Compare
marcoambrosini
approved these changes
Nov 20, 2023
00c7aec
to
4964c16
Compare
4964c16
to
f807a1c
Compare
/compile amend / |
f807a1c
to
30ed7d6
Compare
30ed7d6
to
345379b
Compare
/compile amend / |
LGTM now and can be merged as soon as all CI is green :) |
Signed-off-by: Marco Ambrosini <marcoambrosini@icloud.com> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
345379b
to
be99c1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.