Skip to content

Commit

Permalink
Merge pull request #230 from nextcloud/backport/227/stable30
Browse files Browse the repository at this point in the history
[stable30] fix(flow_notifications): Improve app loading by checking if notificat…
  • Loading branch information
blizzz authored Nov 11, 2024
2 parents ed3be77 + 78d9732 commit d496674
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 1 deletion.
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
### 🔔 Receive notifications
![](screenshots/notification.png)

💡 To use the `Flow Notifications` app, ensure that the [Notifications](https://github.com/nextcloud/notifications) app is installed and enabled. The `Notifications` app provides the necessary APIs for the `Flow Notifications` app to work correctly.

## 🏗 Development setup

1. ☁ Clone this app into the `apps` folder of your Nextcloud: `git clone https://github.com/nextcloud/flow_notifications.git`
Expand Down
2 changes: 2 additions & 0 deletions appinfo/info.xml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
Users are empowered to configure a "Send a notification" Flow in their personal settings. They can choose between the events being triggered, and other conditions like filetypes, assigned tags, time ranges and more. They can specify an inscription so that when the notification appears they will have context.
To use the `Flow Notifications` app, ensure that the `Notifications` app is installed and enabled. The `Notifications` app provides the necessary APIs for the `Flow Notifications` app to work correctly.
![Notification Flow Configuration](https://raw.githubusercontent.com/nextcloud/flow_notifications/master/screenshots/configuration.png)
When an event happens where all conditions are apply, the user will receive a regular Nextcloud notification.
Expand Down
9 changes: 8 additions & 1 deletion lib/Listener/RegisterOperationsListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,23 +27,30 @@

use OCA\FlowNotifications\AppInfo\Application;
use OCA\FlowNotifications\Flow\Operation;
use OCP\App\IAppManager;
use OCP\EventDispatcher\Event;
use OCP\EventDispatcher\IEventListener;
use OCP\Util;
use OCP\WorkflowEngine\Events\RegisterOperationsEvent;
use Psr\Log\LoggerInterface;

/**
* @template-implements IEventListener<Event|RegisterOperationsEvent>
*/
class RegisterOperationsListener implements IEventListener {
public function __construct(
protected readonly Operation $operation
protected readonly Operation $operation,
protected IAppManager $appManager,
private readonly LoggerInterface $logger,
) {
}

public function handle(Event $event): void {
if (!$event instanceof RegisterOperationsEvent) {
return;
} elseif (!$this->appManager->isEnabledForUser('notifications')) {
$this->logger->error('Failed to register `flow_notifications` app. This could happen due to the `notifications` app isn\'t installed or enabled.', ['app' => 'flow_notifications']);
return;
}

$event->registerOperation($this->operation);
Expand Down

0 comments on commit d496674

Please sign in to comment.