Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(npm): bump requirement to 10 and update deps #173

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Jul 24, 2024

With the hope that it fixes the build eventually: https://github.com/nextcloud-releases/flow_notifications/actions/runs/10080135741/job/27870493709

Works locally either way…

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz added the 3. to review Waiting for reviews label Jul 24, 2024
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird failure I would expect CI in here to also fail then 🤷

@blizzz
Copy link
Member Author

blizzz commented Jul 24, 2024

Weird failure I would expect CI in here to also fail then 🤷

Yes, this is puzzling.

@blizzz blizzz merged commit 6f15d88 into master Jul 24, 2024
17 checks passed
@blizzz blizzz deleted the fix/npm-stuff branch July 24, 2024 21:03
@blizzz
Copy link
Member Author

blizzz commented Jul 24, 2024

Unsurprisingly did not help. But less warnings. I wonder where the path [webpack-cli] Failed to load '/home/runner/work/flow_notifications/flow_notifications/flow_notifications/webpack.js' config is coming from, it does not look right.

"fun" fact: v1.9.0 is failed there. Albeit, silently – the whole action went as successful.

@blizzz
Copy link
Member Author

blizzz commented Jul 24, 2024

Okay, Talk had the same issue last week and solved it with: nextcloud/spreed@7194d3b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants