Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one more redirect to finalize login on the GSS slave #150

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

mickenordin
Copy link

This patch will move final login steps back to slave so we can use all login related events on the slave, mostly to enable mfa logins.

Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Copy link
Member

@ArtificialOwl ArtificialOwl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good, i will run some test on my side;
please fix reported syntax issue in the meanwhile !

Makefile Outdated Show resolved Hide resolved
appinfo/info.xml Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Controller/SlaveController.php Outdated Show resolved Hide resolved
lib/Events/AfterLoginOnSlaveEvent.php Show resolved Hide resolved
mickenordin and others added 7 commits March 6, 2024 09:42
* First attempt at slave controlled login flow

Signed-off-by: Micke Nordin <kano@sunet.se>
This patch will make the slave emit a new event "AfterLoginOnSlaveEvent"
right before redirection.

Signed-off-by: Micke Nordin <mickenordin@users.noreply.github.com>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Co-authored-by: Maxence Lange <maxence@artificial-owl.com>
Signed-off-by: Micke Nordin <mickenordin@users.noreply.github.com>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
@mickenordin
Copy link
Author

I think that addressed all of the feedback?

@mickenordin
Copy link
Author

mickenordin commented Apr 17, 2024

@ArtificialOwl what is the status of this? Both the stepupauth[0] app and mfazones[1] app are nearing completion, but will not work with gss without this patchset.

  1. https://apps.nextcloud.com/apps/stepupauth
  2. https://apps.nextcloud.com/apps/mfazones1

Signed-off-by: Micke Nordin <kano@sunet.se>
Co-authored-by: Maxence Lange <maxence@artificial-owl.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants