-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add one more redirect to finalize login on the GSS slave #150
base: master
Are you sure you want to change the base?
Conversation
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good, i will run some test on my side;
please fix reported syntax issue in the meanwhile !
* First attempt at slave controlled login flow Signed-off-by: Micke Nordin <kano@sunet.se>
This patch will make the slave emit a new event "AfterLoginOnSlaveEvent" right before redirection. Signed-off-by: Micke Nordin <mickenordin@users.noreply.github.com> Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Co-authored-by: Maxence Lange <maxence@artificial-owl.com> Signed-off-by: Micke Nordin <mickenordin@users.noreply.github.com> Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
Signed-off-by: Micke Nordin <kano@sunet.se>
I think that addressed all of the feedback? |
@ArtificialOwl what is the status of this? Both the stepupauth[0] app and mfazones[1] app are nearing completion, but will not work with gss without this patchset. |
Signed-off-by: Micke Nordin <kano@sunet.se> Co-authored-by: Maxence Lange <maxence@artificial-owl.com>
This patch will move final login steps back to slave so we can use all login related events on the slave, mostly to enable mfa logins.