Fix wrong object passed to the mount provider in VersionsBackend::getAllVersionedFiles #1725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/more-type-hintin
branch
from
ace283b to
bfdbd0b
Compare
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725 Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/more-type-hintin
branch
from
bfdbd0b to
2f8bb48
Compare
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/more-type-hintin
branch
from
2f8bb48 to
35f0f31
Compare
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/more-type-hintin
branch
from
35f0f31 to
407c539
Compare
CarlSchwan
changed the title
come-nc
reviewed
Nov 4, 2021
come-nc
reviewed
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
work/more-type-hintin
branch
from
407c539 to
bb12117
Compare
come-nc
approved these changes
Nov 4, 2021
|
/backport to stable 22 |
|
/backport to stable22 |
|
/backport to stable21 |
|
/backport to stable20 |
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
backportbot-nextcloud bot
pushed a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
added a commit
that referenced
this pull request
Nov 4, 2021
…AllVersionedFiles `$folder['groups']` is an array from groupId to permission. The mount provider only wants the permission, so since we want to get all the versionned files, just use 31 instead. Before php8, this code was working since using & for an int and an array gave an int. In php8, this now thrown an error. This also include more type hinting that helped me figure out that was wrong. Fix #1725: Signed-off-by: Carl Schwan <carl@carlschwan.eu>
|
Hi Carl, Seems there is a typo in this commit (1725), in lib/Versions/VersionsBackend.php line 36 use OCP\Constant should be use OCP\Constants. on line 160, Constant::PERMISSION_ALL should be Constants::PERMISSION_ALL Thank you for the fix. |
Thanks just pushed a fix to master and stable23. |
|
Sorry seems it's not that simple. I get this error now : /opt/nextcloud/apps/groupfolders/lib/Versions/VersionsBackend.php - line 160: /opt/nextcloud/apps/groupfolders/lib/Versions/GroupVersionsExpireManager.php - line 66: /opt/nextcloud/apps/groupfolders/lib/Versions/GroupVersionsExpireManager.php - line 57: /opt/nextcloud/apps/groupfolders/lib/BackgroundJob/ExpireGroupVersions.php - line 39: /opt/nextcloud/lib/private/BackgroundJob/Job.php - line 51: /opt/nextcloud/lib/private/BackgroundJob/TimedJob.php - line 58: /opt/nextcloud/cron.php - line 127: I Will try to look at what happen, but I don't know the code base that much |
|
Hi @PhMetzger I created a pull request hopefully solving the problem once and for all :) #1753 Could you test it? Bonne soirée :) |
|
Just tested it, and it seems everything is fine. Thank you Carl Guten abend :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$folder['groups']is an array from groupId to permission. The mountprovider only wants the permission, so since we want to get all the
versionned files, just use 31 instead.
Before php8, this code was working since using & for an int and an array
gave an int. In php8, this now thrown an error.
This also include more type hinting that helped me figure out that was
wrong.
Fix #1725