Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore inShare from cli #3433

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Nov 18, 2024

because ::currentUID() is null when executed from occ...

This fix an issue that block access to documents if ACL denies Sharing [1], even if read/write/delete permissions are fine, when calling IUserFolder()->getbyId();

https://github.com/nextcloud/groupfolders/blob/master/lib/ACL/ACLCacheWrapper.php#L35

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the fix/noid/ignore-inshare-on-occ branch from 06325e0 to 28b1548 Compare November 18, 2024 11:09
@ArtificialOwl ArtificialOwl added the 3. to review Items that need to be reviewed label Nov 18, 2024
@come-nc
Copy link
Contributor

come-nc commented Nov 18, 2024

This inShare stuff is weird

@ArtificialOwl ArtificialOwl merged commit 4be5cb0 into master Nov 19, 2024
45 checks passed
@ArtificialOwl ArtificialOwl deleted the fix/noid/ignore-inshare-on-occ branch November 19, 2024 18:07
@ArtificialOwl
Copy link
Member Author

/backport to stable30

@ArtificialOwl
Copy link
Member Author

/backport to stable29

@ArtificialOwl
Copy link
Member Author

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Items that need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants