Show inherited acls #761
Show inherited acls #761
Conversation
Signed-off-by: Miloslav Nenadal <nenadalm@gmail.com>
nenadalm
force-pushed
the
show_inherited_acls
branch
from
e5315f5 to
4c7c49b
Compare
|
I recommend do not allow to delete permission, that is inherited. |
- inherited acls cannot be removed - if non inherited acl is removed, inherited acl takes it's place if any Signed-off-by: Miloslav Nenadal <nenadalm@gmail.com>
I removed the confusing behaviour and now inherited rules cannot be removed. In case they're changed and changed rule is removed, inherited rule takes it's place in the ui. |
|
Thanks a lot for your pull request, looks good from a first quick view, but I'll make sure to give it a proper review and test later this week. |
|
This is a really nice enhancement. Now from a UX perspective I think it would make sense to still somehow indicate that the rule is shown because it is inherited from a parent node. cc @jancborchardt
The group2 entry is fully inherited from the parent (same as user1, but user1 was added as an individual rule to the "Child" directory). I would propose to make sure that the permission icons also get the same opacity level in that case. |
Signed-off-by: Miloslav Nenadal <nenadalm@gmail.com>
nenadalm
force-pushed
the
show_inherited_acls
branch
from
7590814 to
1d0783c
Compare
|
opacity fixed |
Yep, good proposal. @nenadalm thanks for the contribution and the adjustment! :) |
|
so can this PR be approved and merged then, @juliushaertl? |
|
Let me rebase so we can get this in |
|
I've pushed a rebased version of this in #999 since i didn't have push access to your repo. Let me close this PR in favor of the new one then. |
This pr adds inherited advanced rules into the sidebar together with rules for current file. This allows seeing all advanced rules for the file with possibility of changing any rule (rule for current file will be changed in case inherited rule is shown).
When rule is removed in the ui, it is removed from the list and if it was inherited, it will be shown there again after reopening (maybe this should be changed somehow?).