Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #1170

Merged
merged 1 commit into from
Jun 10, 2024
Merged

Fix tests #1170

merged 1 commit into from
Jun 10, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Jun 9, 2024 •
edited
Loading

Static analysis tests are failing on master because of nextcloud/server#44294
This should fix them.

@solracsf
Fix tests
4be0ec2 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf added the 3. to review Waiting for reviews label Jun 9, 2024
@solracsf solracsf marked this pull request as ready for review June 9, 2024 18:03
@solracsf solracsf enabled auto-merge June 9, 2024 18:03
@solracsf solracsf requested review from artonge and skjnldsv June 9, 2024 18:04
@solracsf solracsf merged commit 5f4cffd into master Jun 10, 2024
43 checks passed
@solracsf solracsf deleted the fixWrapperSetOwner branch June 10, 2024 08:33
@github-actions GitHub Actions
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@skjnldsv skjnldsv mentioned this pull request Oct 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@solracsf @artonge