Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(GuestForm): allow to create a guest without name more than once #1178

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Jun 20, 2024

Resolves

To reproduce - create a share with a guest without a name 2 times without page reloading.

  • After creating a guest, the GuestForm modal is reset.
  • During reset, values are set null instead of initial empty string ''
  • Then null is sent to the server that expects a string which causes an error

image

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review Waiting for reviews labels Jun 20, 2024
@ShGKme ShGKme self-assigned this Jun 20, 2024
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 20, 2024

/backport to stable28

@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 20, 2024

/backport! to stable2.5

@Fenn-CS Fenn-CS merged commit ff10aed into master Jun 20, 2024
38 checks passed
@Fenn-CS Fenn-CS deleted the fix/create-guest-without-display-name-twice branch June 20, 2024 11:27
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 20, 2024

/backport to stable2.5

@backportbot backportbot bot added the backport-request Pending backport by the backport-bot label Jun 20, 2024
@backportbot backportbot bot removed the backport-request Pending backport by the backport-bot label Jun 20, 2024
@skjnldsv skjnldsv mentioned this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants