Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #1272

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti… #1272

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

…on which is deprecated

If a user has any notifications this log is generated all the time:

OCA\…\Notification\Notifier::prepare() threw \InvalidArgumentException which is deprecated. Throw \OCP\Notification\UnknownNotificationException when the notification is not known to your notifier and otherwise handle all \InvalidArgumentException yourself.

@nickvergessen
fix(notifications): Notifier::prepare() threw \InvalidArgumentExcepti…
f69bbfb 
…on which is deprecated

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added the 3. to review Waiting for reviews label Dec 20, 2024
@nickvergessen nickvergessen requested a review from Pytal December 20, 2024 14:25
@nickvergessen nickvergessen self-assigned this Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Awaiting requested review from Pytal

At least 1 approving review is required to merge this pull request.

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nickvergessen