Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: appManagement per helm values #530

Closed
wants to merge 1 commit into from

Conversation

wrenix
Copy link
Collaborator

@wrenix wrenix commented Feb 5, 2024

Pull Request

Description of the change

Benefits

Easy Helm-Values management for nextcloud apps

Possible drawbacks

Applicable issues

Additional information

Checklist

Signed-off-by: WrenIX <dev.github@wrenix.eu>
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if this is a good idea.

# config of app
echo "config:"
{{- range $key, $value := $appConfig.config }}
/var/www/html/occ config:app:set -n {{ $app }} {{ $key }} --value="{{ $value }}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases you want to be able to specify the value type, otherwise "true" will be set as a string and not as a boolean.

@wrenix
Copy link
Collaborator Author

wrenix commented Feb 5, 2024

I am also not ( in the past i remeber there was an occ config:app:import command, where old keys are removed) ... maybe i put that into my hook script like in #525 ...

I just like to show the result here.

PS: Thank you for the review marathon the last days. I am really sorry about to being so rough / frustrated.

Comment on lines +166 to +168
apps:
deck:
enabled: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
apps:
deck:
enabled: false
apps:
deck:
enabled: false

I think this fixes the indentation issue? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage apps with hooks
3 participants