Don't require nodePort to template if none is specified
#606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh no, why are all these tests failing? 🤔 Looks like it's because of this error:
Let me see if I can fix it locally... |
|
ok, the fix was remove the |
provokateurin
approved these changes
Jul 26, 2024
jessebot
changed the title
nodePort or template at all if none is specifiednodePort to template if none is specified
jessebot
force-pushed
the
no-node-port
branch
2 times, most recently
from
e2f7672 to
2e7099a
Compare
fixes nextcloud#44 Signed-off-by: jessebot <jessebot@linux.com> Signed-off-by: WrenIX <dev.github@wrenix.eu>
wrenix
force-pushed
the
no-node-port
branch
from
2e7099a to
6f25538
Compare
wrenix
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The actual port that the
NodePorttype service uses can be automatically generated if nonodeportfield is specified, as per the docs here:https://kubernetes.io/docs/concepts/services-networking/service/#type-nodeport
Benefits
We now use a
withinstead of anifto make the code a bit cleaner, instead of setting thenodePortto""which I think may also be confusing and/or not work.Possible drawbacks
none that I can think of, but always open to feedback :)
Applicable issues
Additional information
The actual value of
nilin values.yaml has to change, otherwise, it interprets thenilas a string.Checklist
Chart.yamlaccording to semver.