Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade postgresql to 17.2 (chart 16.3.1) #642

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

GreyXor
Copy link

@GreyXor GreyXor commented Oct 3, 2024

Description of the change

Update postgresql to 17.0 (chart version is 16.0)
close #641

Benefits

@provokateurin
Copy link
Member

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

@GreyXor
Copy link
Author

GreyXor commented Oct 3, 2024

Thanks, the version number of the Chart needs to be bumped as well. @jessebot @wrenix does this justify bumping the major version or would the minor version be enough?

Thanks, I'll update it when we know which version we need here 👍

@wrenix
Copy link
Collaborator

wrenix commented Oct 6, 2024

I have to take a look in the bitmani chart (if it make some migrates).
If not, i will bump a major version (like the bitmani chart too) and write a Changelog / Migration step.

PS: Private i wrote my own postgresql chart and use there the pgautoupgrade as init container (with PGAUTO_ONESHOT=yes) ...

@wrenix
Copy link
Collaborator

wrenix commented Oct 10, 2024

PS: Current PostgreSQL is not supported by Nextcloud (a Warnung appears): nextcloud/server#48495

@provokateurin
Copy link
Member

So better not merge it yet until any Nextcloud version officially supports it. It might just be alright, but better safe than sorry.

@provokateurin provokateurin marked this pull request as draft October 10, 2024 20:46
@jessebot
Copy link
Collaborator

Hoi! Yes, it should be a major update to the chart, as otherwise, it will attempt to upgrade a major version of the database if a user is using the bundled postgresql with this chart. I actually didn't know postgresql was supported by nextcloud at all :O Agree, if it is supported we should wait on this merge.

@GreyXor
Copy link
Author

GreyXor commented Nov 13, 2024

Nextcloud now officially support postgresql 17: nextcloud/server#49240
@provokateurin @wrenix
Thanks 👋

@provokateurin
Copy link
Member

That will only be in Nextcloud 31, so still not ready.

@GreyXor
Copy link
Author

GreyXor commented Nov 13, 2024

That will only be in Nextcloud 31, so still not ready.

In the meantime, waiting for 31. Does this PR seem ready to be merged? Or are there things to add/modify?

@wrenix
Copy link
Collaborator

wrenix commented Nov 15, 2024

nice do You like to make it merge ready? Maybe nextcloud/server@dea6bd7 would be in v30.0.3 ;)

Like to sign-of your commits (DCO check)

@provokateurin
Copy link
Member

would be in v30.0.3

No it won't, it is not on the stable30 branch which means it will be only in Nextcloud 31.

Signed-off-by: GreyXor <greyxor@protonmail.com>
Signed-off-by: GreyXor <greyxor@protonmail.com>
@GreyXor GreyXor changed the title chore: upgrade postgresql to 17.0 (chart 16.0.0) chore: upgrade postgresql to 17.0 (chart 16.2.0) Nov 19, 2024
@GreyXor GreyXor marked this pull request as ready for review November 19, 2024 07:51
@provokateurin
Copy link
Member

Can we please keep it as a draft until we have Nextcloud 31 support in the chart?

@GreyXor GreyXor marked this pull request as draft November 19, 2024 12:35
@GreyXor GreyXor changed the title chore: upgrade postgresql to 17.0 (chart 16.2.0) chore: upgrade postgresql to 17.0 (chart 16.3.1) Dec 13, 2024
@GreyXor GreyXor changed the title chore: upgrade postgresql to 17.0 (chart 16.3.1) chore: upgrade postgresql to 17.2 (chart 16.3.1) Dec 13, 2024
@wrenix wrenix changed the base branch from main to develop December 19, 2024 22:13
@wrenix wrenix force-pushed the develop branch 2 times, most recently from a5582d0 to 8667855 Compare December 19, 2024 22:27
@wrenix wrenix mentioned this pull request Dec 19, 2024
2 tasks
@wrenix wrenix force-pushed the develop branch 3 times, most recently from da98433 to b0d5e60 Compare December 19, 2024 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Update postgresql 17
4 participants