Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add collabora comments and update README to include collabora section #668

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jessebot
Copy link
Collaborator

Description of the change

This just adds some more comments to the collabora chart values, sets the actual defaults of the chart, and updates the README to include those defaults. Also updates the README table of contents.

Benefits

Now our values match the upstream chart, the docs are clearer, and this will hopefully release properly.

Possible drawbacks

Not sure, but always open to chat!

Applicable issues

n/a

Additional information

Checklist

@jessebot jessebot self-assigned this Dec 16, 2024
@jessebot
Copy link
Collaborator Author

Bitnami is unreachable for our other tests right now:

Error: looks like "https://charts.bitnami.com/bitnami" is not a valid chart repository or cannot be reached: Get "https://charts.bitnami.com/bitnami/index.yaml": dial tcp: lookup charts.bitnami.com on 127.0.0.53:53: read udp 127.0.0.1:34715->127.0.0.53:53: i/o timeout

I'll try to rerun them in a bit.

@provokateurin
Copy link
Member

CI was only red because of network issues 😅

@provokateurin provokateurin merged commit 855e033 into main Dec 16, 2024
9 checks passed
@provokateurin provokateurin deleted the add-collabora-comments branch December 16, 2024 17:19
@wrenix
Copy link
Collaborator

wrenix commented Dec 17, 2024

Maybe add also remote_font_url in Dokumentation at collabora.collabora.extra_params: --o:remote_font_config.url

Example:
https://gitlab.opencode.de/bmi/opendesk/deployment/opendesk/-/blob/e4d9106c457e018922dcc730df0570d41f3ec2aa/helmfile/apps/collabora/values.yaml.gotmpl

@jessebot
Copy link
Collaborator Author

@wrenix I looked at that, and thank you, because by reading the docs further and reading that example, it helped me get my collabora helm chart working here!

I'm happy to add that and my other notes to the docs, but what does the remote font config do? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants