Safer auth settings #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-nc
force-pushed
the
fix/noid/safer-auth-settings
branch
from
a4260fc
to
13ae496
Compare
|
rebase please 😇 |
…ributes instead of annotations fix: use correct zammad URL in many places in the backend use password confirmation for sensitive perso/admin setting values fix search result zammad URL if the user uses the admin defined URL Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/safer-auth-settings
branch
from
13ae496
to
cef7a3e
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
fix/noid/safer-auth-settings
branch
from
cef7a3e
to
3b2378f
Compare
|
Rebased. Only thing I kinda reverted is the version for some pkgs in package.json. |
marcelklehr
reviewed
Sep 26, 2024
| "@nextcloud/vue": "8.x", | ||
| "@nextcloud/password-confirmation": "^5.1.1", | ||
| "@nextcloud/router": "^3.0.1", | ||
| "@nextcloud/vue": "^8.16.0", |
There was a problem hiding this comment.
This will not update to 8.17, though, will it?
marcelklehr
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for the long PR. I didn't feel like making 5 PRs 😁
Tested with OAuth and manually set personal token.
@nextcloud/password-confirmation)