Add "allow download" sharing permission attribute #2500
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com>
…missing-sharing-options
mpivchev
changed the title
…missing-sharing-options Signed-off-by: Milen Pivchev <milen.pivchev@gmail.com> # Conflicts: # iOSClient/Data/NCManageDatabase+Share.swift
mpivchev
commented
Jul 7, 2023
Comment on lines
75
to
77
| let attributesInternal = List<ShareAttribute>() | ||
|
|
||
| var attributes = [NKShare.Attribute]() |
There was a problem hiding this comment.
Since Realm wants a List I have to add this internal field
mpivchev
commented
Jul 7, 2023
Comment on lines
173
to
202
| enum NCShareAttribute: NCToggleCellConfig { | ||
| func isOn(for share: NCTableShareable) -> Bool { | ||
| print(share.attributes.first(where: { $0.scope == "permission" && $0.key == "download" })?.enabled == true) | ||
| switch self { | ||
| case.allowDownload: return share.attributes.first(where: { $0.scope == "permission" && $0.key == "download" })?.enabled == true | ||
| } | ||
| } | ||
|
|
||
| func didChange(_ share: NCTableShareable, to newValue: Bool) { | ||
| // TODO: implement | ||
| } | ||
|
|
||
| var title: String { | ||
| switch self { | ||
| case .allowDownload: return NSLocalizedString("_share_attribute_allow_download_", comment: "") | ||
| } | ||
| } | ||
|
|
||
| // func getCell(for share: NCTableShareable) -> UITableViewCell { | ||
| // <#code#> | ||
| // } | ||
| // | ||
| // func didSelect(for share: NCTableShareable) { | ||
| // <#code#> | ||
| // } | ||
|
|
||
| case allowDownload | ||
| static let forAll: [NCShareAttribute] = [.allowDownload] | ||
| } | ||
|
|
There was a problem hiding this comment.
I make another share NCToggleCellConfig, but for attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #2425
WIP