Add other Nextcloud apps to settings as suggestions

[mpivchev]

No description provided.

[mpivchev]

@jancborchardt @marinofaggiana

Here is the new look on phone:

And yes, I noticed that on iPhone 14s (with the new notches) the content does not have any padding (indicated with the red border). This is because we completely ignore the safe area when we render the cells. This is what we do to render them:

 override var frame: CGRect {
        get {
            return super.frame
        }
        set (newFrame) {
            var frame = newFrame
            let newWidth = frame.width * 0.90
            let space = (frame.width - newWidth) / 2
            frame.size.width = newWidth
            frame.origin.x += space
            super.frame = frame
        }
    }

Fixing this is out of scope of this ticket, but I will make a new one after this is finished.

[mpivchev]

Will also test iPad and post it here

[mpivchev]

@jancborchardt This is iPad:

We can either increase the size of the icons or text, or reduce the max width.

[codecov]

Codecov Report

Patch coverage: 7.36% and project coverage change: +0.90% 🎉

Comparison is base (8dbf5fc) 9.37% compared to head (6766167) 10.27%.

❗ Current head 6766167 differs from pull request most recent head 2650a51. Consider uploading reports for the commit 2650a51 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2530      +/-   ##
===========================================
+ Coverage     9.37%   10.27%   +0.90%     
===========================================
  Files          185      188       +3     
  Lines        26355    26354       -1     
  Branches      9827     9833       +6     
===========================================
+ Hits          2471     2709     +238     
+ Misses       23669    23417     -252     
- Partials       215      228      +13     

Files Changed	Coverage Δ
Brand/NCBrand.swift	64.66% <ø> (ø)
.../Extensions/UINavigationController+Extension.swift	43.75% <0.00%> (ø)
iOSClient/More/Cells/BaseNCMoreCell.swift	0.00% <0.00%> (ø)
...OSClient/More/Cells/NCMoreAppSuggestionsCell.swift	0.00% <0.00%> (ø)
iOSClient/More/Cells/NCMoreUserCell.swift	0.00% <0.00%> (ø)
iOSClient/NCGlobal.swift	87.09% <ø> (+54.83%)	⬆️
iOSClient/More/NCMore.swift	2.56% <14.58%> (+0.68%)	⬆️

... and 16 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[marinofaggiana]

please @mpivchev rebase thx

[mpivchev]

@marinofaggiana done. how is this design wise? @jancborchardt ping in case missed

[mpivchev]

@marinofaggiana I fixed the bugs with the missing sections, and from my tests everything was correct (including external sites section), but if you have time please test as well :)

[marinofaggiana]

@marinofaggiana I fixed the bugs with the missing sections, and from my tests everything was correct (including external sites section), but if you have time please test as well :)

good !
but the GUI with iPad and landscape Max I don't like .. try the first two in the left and the "more" on the right and reduce the hight of cell (section) if we really have to put it on at least let it be as bulky as possible :D

[mpivchev]

@marinofaggiana I fixed the bugs with the missing sections, and from my tests everything was correct (including external sites section), but if you have time please test as well :)

good ! but the GUI with iPad and landscape Max I don't like .. try the first two in the left and the "more" on the right and reduce the hight of cell (section) if we really have to put it on at least let it be as bulky as possible :D

That can't really work since it's a stack view

[marinofaggiana]

@marinofaggiana I fixed the bugs with the missing sections, and from my tests everything was correct (including external sites section), but if you have time please test as well :)

good ! but the GUI with iPad and landscape Max I don't like .. try the first two in the left and the "more" on the right and reduce the hight of cell (section) if we really have to put it on at least let it be as bulky as possible :D

That can't really work since it's a stack view

will make some test

[marinofaggiana]

@jancborchardt can be a valid alternative ?

• touch on nextcloud icon up-right
• open menu with talk, note, other

[jancborchardt]

@marinofaggiana this is unfortunately not really discoverable – we had it look very similar years ago where we had only "Files ⏷" displayed in the header, and few people got that Nextcloud was more than other apps. The problem is the same no matter which kind of switcher we have. Directly showing the other apps is a great way to make it very obvious. :)

[jancborchardt]

@mpivchev design-wise, the solution in #2530 (comment) looks great to me. :)

@hannesfritz in case you have input regarding how it looks on iPad – basically a pick between stretching or max-width for the group.

[marinofaggiana]

@mpivchev design-wise, the solution in #2530 (comment) looks great to me. :)

@hannesfritz in case you have input regarding how it looks on iPad – basically a pick between stretching or max-width for the group.

@mpivchev I prefer the maximum width at this point (iPad, max) ...

[mpivchev]

@marinofaggiana @jancborchardt I think currently it looks ok and keeping going back on forth on the design is a waste of time. Waiting for approval on the code.

[marinofaggiana]

@mpivchev Resolve conflicts and merge thanks!

[mpivchev]

@marinofaggiana Added the flag + reduce complexity of section code. Tested with flag to true + external site menu and it seems to work fine.

@Ivansss @tobiasKaminsky NCBrand has a new flag disable_show_more_nextcloud_apps_in_settings that shows or hides the more apps section. Default is false. Should be set to true for Brand releases in brander etc.

New things

[jancborchardt]

All good design-wise! :)

[marinofaggiana]

the showMoreAppsSection must be moved in NCBrand, as disable_NextcloudApps

[marinofaggiana]

please make a rebase

[marinofaggiana]

why use the address apple ?
use the app scheme, if do not open you can open the "https://www.apple.com/us/search/nextcloud?src=globalnav"

example
// nextcloudtalk://open-conversation?server={serverURL}&user={userId}&withRoomToken={roomToken}
if metadata.name == NCGlobal.shared.talkName {
let pathComponents = metadata.url.components(separatedBy: "/")
if pathComponents.contains("call") {
let talkComponents = pathComponents.last?.components(separatedBy: "#")
if let roomToken = talkComponents?.first {
let urlString = "nextcloudtalk://open-conversation?server=(appDelegate.urlBase)&user=(appDelegate.userId)&withRoomToken=(roomToken)"
if let url = URL(string: urlString), UIApplication.shared.canOpenURL(url) {
... bla bla bla
return
}
}
}
}

[mpivchev]

I check if the app is already installed, if not them we open the app store page.

[marinofaggiana]

yes, but this is the page open in emulator (Talk)

[marinofaggiana]

the use of app scheme nextcloudtalk:// avoids these problems

[mpivchev]

That's what I use, check the code. The app store does not open in the simulator, you have to test on actual device.

[marinofaggiana]

Understand but this
https://github.com/nextcloud/NextcloudKit/blob/a5bad2b6238ac25b3a59c9e7d91826b4f74c16c3/Sources/NextcloudKit/NKShareAccounts.swift#L120
works in simultor and not and do not required the link to apple

let talkSchemeUrl = "nextcloudtalk://"
let notesSchemeUrl = "nextcloudnotes://"

we have already all so this, so you can use thappstorelink for open the browser "https://www.apple.com/us/search/nextcloud?src=globalnav" (works with emulator)