Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize ncshareaccounts #3112

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Optimize ncshareaccounts #3112

wants to merge 2 commits into from

Commits on Oct 20, 2024

  1. Update NCAccountRequest.swift 

    Improved memory management by using a weak reference for the Timer to prevent potential retain cycles.
Refactored repeated cell configuration logic into a helper function to improve code readability and maintainability.
Optimized UI updates to avoid unnecessary progress view updates, enhancing performance.
Ensured proper invalidation of the timer to prevent it from running in the background when not needed.
No changes to external behavior or API; the functionality remains consistent with the original implementation.

Signed-off-by: Jonny Ulloa <127699789+jonnyulloa@users.noreply.github.com>
    @jonnyulloa
    jonnyulloa authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    113f169 View commit details
    Browse the repository at this point in the history

  2. Performance and Code Cleanup for NCShareAccounts.swift 

    Improved memory management by ensuring the delegate is weak to prevent retain cycles.
Refactored repetitive cell configuration code into a helper function to enhance code readability and maintainability.
Optimized UI behavior to avoid unnecessary scroll calculations.
Maintained the same external behavior and API, ensuring no changes to the user experience or app functionality.

Signed-off-by: Jonny Ulloa <127699789+jonnyulloa@users.noreply.github.com>
    @jonnyulloa
    jonnyulloa authored Oct 20, 2024
    Configuration menu
    Copy the full SHA
    37ee7e5 View commit details
    Browse the repository at this point in the history