Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add psalm #108

Merged
merged 7 commits into from
Dec 21, 2023
Merged

Add psalm #108

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
636bf21
Add psalm workflow, script and configuration
come-nc Dec 19, 2023
93768bb
Add stubs and sabre/dav dev dependency for psalm
come-nc Dec 19, 2023
615af0a
Fix issues reported by psalm
come-nc Dec 19, 2023
5cc8997
Enable LDAP module for psalm CI
come-nc Dec 19, 2023
0c18b20
Force PHP version for psalm to check to 8.0
come-nc Dec 19, 2023
3515bab
Bump coding-standard to 1.1
come-nc Dec 19, 2023
a37eac7
composer run cs:fix
come-nc Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 36 additions & 0 deletions .github/workflows/psalm.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
# This workflow is provided via the organization template repository
#
# https://github.com/nextcloud/.github
# https://docs.github.com/en/actions/learn-github-actions/sharing-workflows-with-your-organization

name: Static analysis

on: pull_request

concurrency:
group: psalm-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
static-analysis:
runs-on: ubuntu-latest

name: static-psalm-analysis
steps:
- name: Checkout
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

- name: Set up php8.2
uses: shivammathur/setup-php@e6f75134d35752277f093989e72e140eaa222f35 # v2
with:
php-version: 8.2
coverage: none
ini-file: development
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

- name: Install dependencies
run: composer i

- name: Run coding standards check
run: composer run psalm
9 changes: 7 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,9 @@
"require-dev": {
"phpunit/phpunit": "^9",
"nextcloud/coding-standard": "^1.0.0",
come-nc marked this conversation as resolved.
Show resolved Hide resolved
"nextcloud/ocp": "dev-master"
"nextcloud/ocp": "dev-master",
"vimeo/psalm": "^5.18",
"sabre/dav": "4.5.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you use it directly?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://github.com/nextcloud/ldap_contacts_backend/blob/main/lib/Model/Card.php#L28-L32

},
"require": {
"symfony/ldap": "^5.0"
Expand All @@ -25,7 +27,10 @@
"lint": "find . -name \\*.php -not -path './vendor/*' -not -path './build/*' -print0 | xargs -0 -n1 php -l",
"cs:check": "php-cs-fixer fix --dry-run --diff",
"cs:fix": "php-cs-fixer fix",
"test:unit": "vendor/bin/phpunit -c tests/phpunit.xml"
"test:unit": "vendor/bin/phpunit -c tests/phpunit.xml",
"psalm": "psalm --no-cache --threads=$(nproc)",
"psalm:fix": "psalm --alter --issues=InvalidReturnType,InvalidNullableReturnType,MissingParamType,InvalidFalsableReturnType",
"psalm:update-baseline": "psalm --threads=1 --update-baseline"
},
"autoload-dev": {
"psr-4": {
Expand Down
Loading
Loading