Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust testing matrix for Nextcloud 25 on main #7306

Merged
merged 1 commit into from
Sep 28, 2022
Merged

Adjust testing matrix for Nextcloud 25 on main #7306

merged 1 commit into from
Sep 28, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented Sep 22, 2022 •
edited by ChristophWurst
Loading

@nickvergessen nickvergessen mentioned this pull request Sep 22, 2022
Closed
54 tasks
@miaulalala
Copy link
Contributor

miaulalala commented Sep 22, 2022 •
edited
Loading

this needs to be a bit more elaborate. Stable branches lower than 2 need to run against NC stable24. everything higher needs to run against 25+
Overthinking this.

cc @ChristophWurst

@miaulalala miaulalala mentioned this pull request Sep 26, 2022
Merged
ChristophWurst
ChristophWurst reviewed Sep 26, 2022
View reviewed changes
.github/workflows/test.yml Outdated
@@ -16,7 +16,7 @@ jobs:
strategy:
matrix:
php-versions: ['7.4', '8.0', '8.1', '8.2']
nextcloud-versions: ['master']
nextcloud-versions: ['master', 'stable25']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's include just one job or we will go from 4 test jobs to 8. 5 should be plenty.

@nickvergessen @ChristophWurst
Adjust testing matrix for Nextcloud 25 on main
012e8f0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@ChristophWurst ChristophWurst merged commit 7940640 into main Sep 28, 2022
@ChristophWurst ChristophWurst deleted the update-main-target-versions branch September 28, 2022 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@CarlSchwan CarlSchwan CarlSchwan approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nickvergessen @miaulalala @ChristophWurst @CarlSchwan @GretaD