Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(setup): Rate limit auto config attempts #8709

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

ChristophWurst
Copy link
Member

If a user sends more attempts they either have incorrect options anyway or just try to overload the server.

How to test

  1. Open the app
  2. Click + New account in the navigation
  3. Enter some invalid email address
  4. Hammer the Connect button

main: You can try endlessly
here: You can try a bunch of times, then you see a nice error message:

image

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst
Copy link
Member Author

/backport to stable3.3

@ChristophWurst
Copy link
Member Author

/backport to stable3.2

@ChristophWurst
Copy link
Member Author

/backport to stable2.2

Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@GretaD GretaD merged commit 65f3670 into main Aug 10, 2023
29 checks passed
@GretaD GretaD deleted the fix/setup/rate-limit-auto-config-attempts branch August 10, 2023 11:19
@backportbot-nextcloud
Copy link

The backport to stable2.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable2.2
git pull origin stable2.2

# Create the new backport branch
git checkout -b fix/foo-stable2.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable2.2

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@ChristophWurst
Copy link
Member Author

/backport to stable2.2

@backportbot-nextcloud
Copy link

The backport to stable2.2 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable2.2
git pull origin stable2.2

# Create the new backport branch
git checkout -b fix/foo-stable2.2

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable2.2

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants