Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.1.4: Could not extract app maps #240

Closed
vanitasvitae opened this issue Jan 18, 2020 · 45 comments
Closed

0.1.4: Could not extract app maps #240

vanitasvitae opened this issue Jan 18, 2020 · 45 comments

Comments

@vanitasvitae
Copy link

Hi!
Updating maps fro 0.1.2 to 0.1.4 fails for me:

[core] Error: Exception: Could not extract app maps at <<closure>>

0. /var/www/nextcloud/lib/private/Installer.php line 186
   OC\Installer->downloadApp("*** sensitive parameter replaced ***")
1. /var/www/nextcloud/settings/Controller/AppSettingsController.php line 532
   OC\Installer->updateAppstoreApp("*** sensitive parameters replaced ***")
2. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 170
   OC\Settings\Controller\AppSettingsController->updateApp("*** sensitive parameters replaced ***")
3. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 99
   OC\AppFramework\Http\Dispatcher->executeController(OC\Settings\Cont ... {}, "updateApp")
4. /var/www/nextcloud/lib/private/AppFramework/App.php line 126
   OC\AppFramework\Http\Dispatcher->dispatch(OC\Settings\Cont ... {}, "updateApp")
5. /var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
   OC\AppFramework\App::main("OC\\Settings\\C ... r", "updateApp", OC\AppFramework\ ... {}, {appId: "*** sen ... "})
6. <<closure>>
   OC\AppFramework\Routing\RouteActionHandler->__invoke({appId: "*** sen ... "})
7. /var/www/nextcloud/lib/private/Route/Router.php line 297
   undefinedundefinedcall_user_func(OC\AppFramework\ ... {}, {appId: "*** sen ... "})
8. /var/www/nextcloud/lib/base.php line 997
   OC\Route\Router->match("/settings/apps/update/maps")
9. /var/www/nextcloud/index.php line 42
   OC::handleRequest()

GET /settings/apps/update/maps

I'm running NC 17.0.2 on Debian Buster.

@tacruc
Copy link
Collaborator

tacruc commented Jan 18, 2020

@rullzer do you have an idea. Tar is extracting the archive without error.

@gringo1er
Copy link

Same issue. By nextcloud integrated update interface, or by downloading tar on apps.nextcloud.com : "corrupted archive"
Thanks!

@small1
Copy link

small1 commented Jan 18, 2020

Cant install or update to latest maps on any of my instances.

@JoshuaPettus
Copy link

Same for me NC 17.0.2, PHP 7.3.13, Ubuntu 18.04

@xila76
Copy link

xila76 commented Jan 18, 2020

Same for me NC 17.0.2, PHP 7.3, Debian Buster
But update can be done manually in SSH after downloading tar archive from github releases page and extracting it

@poVoq
Copy link

poVoq commented Jan 18, 2020

Happens for me also for the 18.0.0RC2-apache docker image.

@tacruc tacruc pinned this issue Jan 18, 2020
@tacruc
Copy link
Collaborator

tacruc commented Jan 18, 2020

We're investigating. Manually unpacking is working.

@vanitasvitae
Copy link
Author

Manually installing worked for me too. Nice update! :D

@Rychu-Pawel
Copy link

I'll only add that update through occ fails too.

@palto42
Copy link

palto42 commented Jan 18, 2020

In the NC logs I see a message about signature issue: "Exception: App with id maps has invalid signature"

@vanitasvitae
Copy link
Author

In the NC logs I see a message about signature issue: "Exception: App with id maps has invalid signature"

That sounds more like #237. Are you sure you are trying to update to 0.1.4, not 0.1.3?

@doc75
Copy link
Contributor

doc75 commented Jan 18, 2020

Same issue with Nextcloud 16.0.7 while trying to upgrade from v0.1.2 to v0.1.4.
Thanks for this great app.

@palto42
Copy link

palto42 commented Jan 18, 2020

In the NC logs I see a message about signature issue: "Exception: App with id maps has invalid signature"

That sounds more like #237. Are you sure you are trying to update to 0.1.4, not 0.1.3?

Thanks @vanitasvitae , you are right. It was an older log entry from this morning.

@oakbrad
Copy link

oakbrad commented Jan 18, 2020

Happens for me also for the 18.0.0RC2-apache docker image.

Same for me after updating to 18.0.0-apache Docker image

@olipinski
Copy link

Same on NC 17.0.2, PHP 7.2.24, Ubuntu 18.04.3

@jancborchardt
Copy link
Member

cc @rullzer @tacruc @eneiluj cause I can’t mediate on this technical issue. What can we do here and/or how can we communicate?

Do we load the extra Mapbox library only after initial install, or how do we keep the package smaller?

@lyn1337
Copy link

lyn1337 commented Jan 19, 2020

Update failed for me on NC16, same error.
Removing and re-installing failed.
# sudo -u www-data php -f occ app:install maps Error: Could not extract app maps

@makemegit
Copy link

makemegit commented Jan 19, 2020

Guys when i download as zip, there is a comment inside:

4cb2861660711a06ded5a481331022b25e6c9b2a

What is this? md5 sha1, 256 ?

I am asking because:

$ sha1sum maps-master.zip
51c33b80746d539666fff72d436fac553f70aa2f maps-master.zip

@lyn1337
Copy link

lyn1337 commented Jan 19, 2020

@makemegit the id of the latest commit

@UDZGuru
Copy link

UDZGuru commented Jan 19, 2020

I am also affected by the "could not extract" issue.

NC17.02, PHP7.3.11, MariaDB 10.3.20

This is the first time an app fails to update. All other apps worked just fine.

@szucher
Copy link

szucher commented Jan 19, 2020

Hi,
i have the same error. I tried to uninstall the app and try to install again, but this also failed!
Please fix it fast! When the App works, its a very good App!

@mikweb2017
Copy link

i have the same error. NC 18 PHP 7.3.13

@Bschalck
Copy link

Bschalck commented Jan 19, 2020

same error here :
Nextcloud 17.0.2 , php 7.13.3
{"reqId":"QQh30CPtOFv5WLRvZa5C","level":3,"time":"2020-01-19T10:54:20+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":{"Exception":"Exception","Message":"Could not extract app maps","Code":0,"Trace":[{"file":"\/home\/nextcloud\/lib\/private\/Installer.php","line":186,"function":"downloadApp","class":"OC\\Installer","type":"->","args":["*** sensitive parameter replaced ***"]},{"file":"\/home\/nextcloud\/core\/Command\/App\/Update.php","line":105,"function":"updateAppstoreApp","class":"OC\\Installer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Command\/Command.php","line":255,"function":"execute","class":"OC\\Core\\Command\\App\\Update","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":908,"function":"run","class":"Symfony\\Component\\Console\\Command\\Command","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":269,"function":"doRunCommand","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"OC\\Core\\Command\\App\\Update"},{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":145,"function":"doRun","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/lib\/private\/Console\/Application.php","line":213,"function":"run","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/console.php","line":97,"function":"run","class":"OC\\Console\\Application","type":"->","args":[]},{"file":"\/home\/nextcloud\/occ","line":11,"args":["\/home\/nextcloud\/console.php"],"function":"require_once"}],"File":"\/home\/nextcloud\/lib\/private\/Installer.php","Line":283,"CustomMessage":"--"},"userAgent":"--","version":"17.0.2.1"} {"reqId":"QQh30CPtOFv5WLRvZa5C","level":3,"time":"2020-01-19T10:54:20+00:00","remoteAddr":"","user":"--","app":"core","method":"","url":"--","message":{"Exception":"Exception","Message":"Could not extract app maps","Code":0,"Trace":[{"file":"\/home\/nextcloud\/lib\/private\/Installer.php","line":186,"function":"downloadApp","class":"OC\\Installer","type":"->","args":["*** sensitive parameter replaced ***"]},{"file":"\/home\/nextcloud\/core\/Command\/App\/Update.php","line":105,"function":"updateAppstoreApp","class":"OC\\Installer","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Command\/Command.php","line":255,"function":"execute","class":"OC\\Core\\Command\\App\\Update","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":908,"function":"run","class":"Symfony\\Component\\Console\\Command\\Command","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":269,"function":"doRunCommand","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"OC\\Core\\Command\\App\\Update"},{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/3rdparty\/symfony\/console\/Application.php","line":145,"function":"doRun","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/lib\/private\/Console\/Application.php","line":213,"function":"run","class":"Symfony\\Component\\Console\\Application","type":"->","args":[{"__class__":"Symfony\\Component\\Console\\Input\\ArgvInput"},{"__class__":"Symfony\\Component\\Console\\Output\\ConsoleOutput"}]},{"file":"\/home\/nextcloud\/console.php","line":97,"function":"run","class":"OC\\Console\\Application","type":"->","args":[]},{"file":"\/home\/nextcloud\/occ","line":11,"args":["\/home\/nextcloud\/console.php"],"function":"require_once"}],"File":"\/home\/nextcloud\/lib\/private\/Installer.php","Line":283,"CustomMessage":"--"},"userAgent":"--","version":"17.0.2.1"}

@rullzer
Copy link
Member

rullzer commented Jan 19, 2020

I'm not at my laptop. But it seems there are two issues here.

  1. Timeout, this is not something we can really fix. But downloading the file manually should fix it.
  2. It seems some systems find the package as not properly signed. I can look into that tomorrow if that is really true or not and if so what to do.

@ghost
Copy link

ghost commented Jan 19, 2020

Due to the Document Server (it is a realy big "app"), I have changed my download timeout, so this should fixed for me, but anyway:
Exception: Could not extract app maps

@mseed
Copy link

mseed commented Jan 19, 2020

Same problem on my NextCloud 17.0.2 servers.

[core] Error: Exception: Could not extract app maps at <<closure>>

0. /var/www/nextcloud/lib/private/Installer.php line 186
   OC\Installer->downloadApp("*** sensitive parameter replaced ***")
1. /var/www/nextcloud/settings/Controller/AppSettingsController.php line 532
   OC\Installer->updateAppstoreApp("*** sensitive parameters replaced ***")
2. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 170
   OC\Settings\Controller\AppSettingsController->updateApp("*** sensitive parameters replaced ***")
3. /var/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php line 99
   OC\AppFramework\Http\Dispatcher->executeController(OC\Settings\Cont ... {}, "updateApp")
4. /var/www/nextcloud/lib/private/AppFramework/App.php line 126
   OC\AppFramework\Http\Dispatcher->dispatch(OC\Settings\Cont ... {}, "updateApp")
5. /var/www/nextcloud/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
   OC\AppFramework\App::main("OC\\Settings\\C ... r", "updateApp", OC\AppFramework\ ... {}, {appId: "*** sen ... "})
6. <<closure>>
   OC\AppFramework\Routing\RouteActionHandler->__invoke({appId: "*** sen ... "})
7. /var/www/nextcloud/lib/private/Route/Router.php line 297
   undefinedundefinedcall_user_func(OC\AppFramework\ ... {}, {appId: "*** sen ... "})
8. /var/www/nextcloud/lib/base.php line 997
   OC\Route\Router->match("/settings/apps/update/maps")
9. /var/www/nextcloud/index.php line 42
   OC::handleRequest()

GET /settings/apps/update/maps

@dugite-code
Copy link

@alex-noname you need to download from the release page not the git repo https://github.com/nextcloud/maps/releases/tag/v0.1.4

sudo -u www-data php occ app:disable maps
cd apps
mv ./maps ./maps-old
wget https://github.com/nextcloud/maps/releases/download/v0.1.4/maps-0.1.4.tar.gz
tar -xzvf maps-0.1.4.tar.gz
chown -R www-data:www-data ./maps
cd ..
sudo -u www-data php occ app:enable maps

@ralfi
Copy link

ralfi commented Jan 20, 2020

manual install like above works like a charme ...

@alex-noname
Copy link

@dugite-code
Thanks a lot. It works for me too.

@rullzer
Copy link
Member

rullzer commented Jan 21, 2020

That is because manual install doesn't verify the signature that is in the appstore.

Seems indeed that the signature doesn't match.
Could you resign the tarball and try to release it again?

@alex-noname
Copy link

Could you resign the tarball and try to release it again?

I agree. It would be the safest, best, and most trustworthy option.

@probastaller
Copy link

Same case here.
NC 17.0.2 nginx.

  • Installed manually and it is working fine :)

@makemegit
Copy link

@dugite-code 10x . It works.

@SomeStrangeName
Copy link

Now I see 0.1.3 as version in nextcloud admint page. But seems to have the same error.

@Art4
Copy link

Art4 commented Jan 21, 2020

@SomeStrangeName 0.1.3 has a bug #237, that should be fixed in 0.1.4, but results in this bug. 🙈

@tacruc
Copy link
Collaborator

tacruc commented Jan 21, 2020

That is because manual install doesn't verify the signature that is in the appstore.

Seems indeed that the signature doesn't match.
Could you resign the tarball and try to release it again?

I build a new tarball and updated it on the appstore but the error is still there. If I manually download the archive and compare the Signatures match. Do you have more insight which signature might be wrong.

Issue #237 is from the time where I updated the tarball on github but not yet in the appstore.

@tacruc
Copy link
Collaborator

tacruc commented Jan 21, 2020

There is something wired with the old and the new archive.

<?php
require_once 'Archive/Tar.php';

$tar =  new Archive_Tar("maps-.tar.gz","gz");
if(!$tar->extract("./")){
    echo("Error\n");
}

Unpacks the Archive, but the script outputs Error too.

@lupinehorror
Copy link

i'm getting this too. nextcloud 17.0.2 trying to upgrade to maps 0.1.4

[core] Error: Exception: Could not extract app maps at <>

  1. /web/lib/private/Installer.php line 186
    OC\Installer->downloadApp("
    ** sensitive parameter replaced ***")
  2. /web/settings/Controller/AppSettingsController.php line 532
    OC\Installer->updateAppstoreApp("
    ** sensitive parameters replaced ***")
  3. /web/lib/private/AppFramework/Http/Dispatcher.php line 170
    OC\Settings\Controller\AppSettingsController->updateApp("
    ** sensitive parameters replaced ***")
  4. */web/lib/private/AppFramework/Http/Dispatcher.php line 99
    OC\AppFramework\Http\Dispatcher->executeController(OC\Settings\Cont ... {}, "updateApp")
  5. */web/lib/private/AppFramework/App.php line 126
    OC\AppFramework\Http\Dispatcher->dispatch(OC\Settings\Cont ... {}, "updateApp")
  6. /web/lib/private/AppFramework/Routing/RouteActionHandler.php line 47
    OC\AppFramework\App::main("OC\Settings\C ... r", "updateApp", OC\AppFramework\ ... {}, {appId: "
    ** sen ... "})
  7. <>
    OC\AppFramework\Routing\RouteActionHandler->__invoke({appId: "*** sen ... "})
  8. /web/lib/private/Route/Router.php line 297
    undefinedundefinedcall_user_func(OC\AppFramework\ ... {}, {appId: "
    ** sen ... "})
  9. */web/lib/base.php line 997
    OC\Route\Router->match("/settings/apps/update/maps")
  10. */web/index.php line 42
    OC::handleRequest()

GET /index.php/settings/apps/update/maps

@tacruc
Copy link
Collaborator

tacruc commented Jan 22, 2020

Ok, if i take the archive created by the makefile (with tar -czf) the test script two post above fails, but if I compress the folder created by the makefile using ark, the testscript passes. So I will try to upload a manually compressed archive and see if it helps.

@Bschalck
Copy link

For information, same erreor whan download app on clean NExctloud 18 server :
Une erreur est survenue durant la requête. Impossible de traiter la demande.
App with id maps has invalid signature

@tacruc
Copy link
Collaborator

tacruc commented Jan 22, 2020

Ok, if i take the archive created by the makefile (with tar -czf) the test script two post above fails, but if I compress the folder created by the makefile using ark, the testscript passes. So I will try to upload a manually compressed archive and see if it helps.

The new build worked for me. Please notice that there are still some open issues:
Most curtial ones:
#239
#261
#260
#247

@tjeerd13
Copy link

My solution for:

Maps installing with the App installer did not work. (removed en try to reinstall different times.)

I'm not using the default www-data user. I noticed the wrong permsions in the /app/maps map. And there whas a maps-master.zip file in the /app map. With root as owner. After removing that file and removing the /app/maps map. I could use the web installer again and its al working fine now,

@scottpk
Copy link

scottpk commented Jan 24, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests