Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show share count when no file is uploaded #11

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Show share count when no file is uploaded #11

merged 1 commit into from
Apr 11, 2022

Conversation

CarlSchwan
Copy link
Member

No description provided.

@CarlSchwan CarlSchwan self-assigned this Apr 4, 2022
@juliusknorr
Copy link
Member

Tests and php-cs need another fix:

1) OCA\MonthlyStatusEmail\Tests\MailSenderTest::testStorageSafe
[21](https://github.com/nextcloud/monthly_status_email/runs/5824619290?check_suite_focus=true#step:9:21)
OCP\Share\IManager::getSharesBy(null, 0, null, false, 100, 0) was not expected to be called.
[22](https://github.com/nextcloud/monthly_status_email/runs/5824619290?check_suite_focus=true#step:9:22)

[23](https://github.com/nextcloud/monthly_status_email/runs/5824619290?check_suite_focus=true#step:9:23)
/home/runner/work/monthly_status_email/monthly_status_email/apps/monthly_status_email/lib/Service/MailSender.php:288
[24](https://github.com/nextcloud/monthly_status_email/runs/5824619290?check_suite_focus=true#step:9:24)
/home/runner/work/monthly_status_email/monthly_status_email/apps/monthly_status_email/lib/Service/MailSender.php:208
[25](https://github.com/nextcloud/monthly_status_email/runs/5824619290?check_suite_focus=true#step:9:25)
/home/runner/work/monthly_status_email/monthly_status_email/apps/monthly_status_email/tests/MailSenderTest.php:224

@CarlSchwan
Show share count when no file uploaded
fb7ef19 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
@CarlSchwan CarlSchwan force-pushed the fix/show-share-count-when-no-mail-uploaded branch from badd1db to fb7ef19 Compare April 11, 2022 17:11
@juliusknorr juliusknorr merged commit 7bbaa51 into master Apr 11, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/show-share-count-when-no-mail-uploaded branch April 11, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees

@CarlSchwan CarlSchwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarlSchwan @juliusknorr