Fix getting consecutive storage info #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
commented
May 12, 2022
CarlSchwan
force-pushed
the
fix/storage-info
branch
4 times, most recently
from
d37c71d
to
7e4f22e
Compare
juliusknorr
approved these changes
May 13, 2022
The issue is that OC_Helper is using Filesystem internally and Filesystem, will only use the same View for each users, so we were basically only calculating the size once when processing multiple users. Signed-off-by: Carl Schwan <carl@carlschwan.eu>
CarlSchwan
force-pushed
the
fix/storage-info
branch
from
7e4f22e
to
1211200
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue is that OC_Helper is using Filesystem internally and
Filesystem, will only use the same View for each users, so we were
basically only calculating the size once when processing multiple users.
In the future, storage and quota calculation needs to be cleaned in server
and provided as a public API