Fix unique constrains #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
fix/unique-constrains
branch
from
a989876
to
fcff4e6
Compare
CarlSchwan
requested review from
juliusknorr,
a team,
blizzz,
vanpertsch and
nickvergessen
and removed request for
a team
nickvergessen
requested changes
Mar 4, 2022
CarlSchwan
force-pushed
the
fix/unique-constrains
branch
2 times, most recently
from
2dbb18d
to
c2d04fb
Compare
PVince81
reviewed
Mar 7, 2022
PVince81
reviewed
Mar 7, 2022
CarlSchwan
force-pushed
the
fix/unique-constrains
branch
from
c2d04fb
to
630cbab
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu> Co-Authored-By: Joas Schilling <coding@schilljs.com>
CarlSchwan
force-pushed
the
fix/unique-constrains
branch
from
ea75799
to
1813662
Compare
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
nickvergessen
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix an issue where the unique index created was for a pair of <userId, token> instead of having a unique index on the userId and a unique index on the token.
If there are more than one entry with the same userId, we delete the other one. It's safe because we need at most one and the other one will just generate additional noice.
Signed-off-by: Carl Schwan carl@carlschwan.eu