Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When opening a feed, oldest article is selected instead of newest. #1324

Closed
3 tasks done
mjanssens opened this issue Apr 30, 2021 · 12 comments · Fixed by #1791
Closed
3 tasks done

When opening a feed, oldest article is selected instead of newest. #1324

mjanssens opened this issue Apr 30, 2021 · 12 comments · Fixed by #1791
Labels
bug frontend impact Javascript/Frontend code

Comments

@mjanssens
Copy link

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Since 15.4.0 the oldest article in a feed is selected by default.
So with default sorting (newest on top), the selected item is by default on the bottom.
Keyboard shortcut n/j/right has no effect, because it's the last article in the list.

Steps to Reproduce

Explain what you did to encounter the issue

  1. Reverse sorting is not enabled
  2. Open a feed
  3. Feed articles are sorted top down from newest to oldest, as in previous versions of the news app
  4. Press keyboard right key
  5. Nothing happens
  6. when scrolling down, you see that the oldest item is selected, so that's why next article shortcut doesn't go to next article.

When selecting reverse sorting, you see that the oldest article is still selected, but now it's on the top of the list, and keyboard shortcut as effect.

System Information

  • News app version: 15.4.0
  • Nextcloud version: 21.0.1
  • Cron type: system cron
  • PHP version: 7.3.27
  • Database and version: PostgreSQL 11.11
  • Browser and version: Firefox 88.0
  • OS and version: Debian 10.9
@mjanssens mjanssens added the bug label Apr 30, 2021
@Grotax Grotax added the frontend impact Javascript/Frontend code label Apr 30, 2021
@mjanssens
Copy link
Author

A workaround for now, without enabling reverse sorting order.
Click the first article with mouse. Then use the keyboard shortcuts as usual.

@SMillerDev
Copy link
Contributor

It seems the newestItem in the API response is not in fact the latest item in the list. This might be because of the difference between sorting in the list id and the real world lastUpdatedTime

@bhtooefr
Copy link

Worth noting that, from what I'm seeing, this isn't technically selecting the oldest article, but rather the oldest visible article in the current view (it may be the oldest loaded, not oldest visible, I haven't tried shrinking the browser window after opening a feed), at least with newest on top sorting, with 15.4.5.

So, if I have 500 unread articles, and my browser window is large enough to show 30, opening the unread articles view and pressing n selects the 30th newest article, not the oldest (500th newest). (Expected behavior is for it to select the newest article, of course.)

@stale
Copy link

stale bot commented Jul 21, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 21, 2021
@feutl
Copy link

feutl commented Jul 21, 2021

This issue is still not fixed on my instance running NC 21.0.3 and News 16.0.0

@stale stale bot removed the stale label Jul 21, 2021
@mdkcore0
Copy link

mdkcore0 commented Sep 3, 2021

same on my instance (NC 22.1.0 and News 16.0.1)

@weierophinney
Copy link

Same - NC 22.2.3 and News 17.0.1 here.

@feutl
Copy link

feutl commented Mar 9, 2022

What is the status on this ?
I am seeing new app updates quite often - which I really appreciate, but this issue is really annoying and I would like to see it fixed.

I know I know, volunteers and I could help too. I understand all of this, but this is my way of helping, by asking and bringing the focus back to the issue.

Thanks

@Grotax
Copy link
Member

Grotax commented Mar 9, 2022

No development on the frontend side, updates only change the backend parts or automatically update dependencies.
There is no one in the project that wants to work on the frontend.

@feutl
Copy link

feutl commented Mar 12, 2022

well, sad but understandable.
Thanks for the honesty.

@stale
Copy link

stale bot commented Apr 16, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Apr 16, 2022
@bhtooefr
Copy link

Still present in Nextcloud 23.0.3 with News 18.0.0.

@stale stale bot removed the stale label Apr 17, 2022
AccaliaDeElementia added a commit to AccaliaDeElementia/nextcloud-news that referenced this issue May 23, 2022
AccaliaDeElementia added a commit to AccaliaDeElementia/nextcloud-news that referenced this issue May 23, 2022
Signed-off-by: Accalia <Accalia@Elementia.me>
Grotax pushed a commit that referenced this issue May 24, 2022
Signed-off-by: Accalia <Accalia@Elementia.me>
Grotax added a commit that referenced this issue May 29, 2022
Changed
- Add API v1.3 adding routes for starring/unstarring items by id and general fixes (#1727)
  https://nextcloud.github.io/news/api/api-v1-3/
- Improve styling of tables in articles (#1779)
- Allow fetching feeds that omit guid by using link as stand-in (#1785)

Fixed
- Fix updated api not returning any item after marking item as read (#1713)
- Fix deprecation warning for strip_tags() on a null value (#1766)
- Fix selected item being set incorrectly when using default ordering or newest first ordering (#1324)
- Fix doubling the height of the content area (#1796)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax added a commit that referenced this issue May 29, 2022
Changed
- Add API v1.3 adding routes for starring/unstarring items by id and general fixes (#1727)
  https://nextcloud.github.io/news/api/api-v1-3/
- Improve styling of tables in articles (#1779)
- Allow fetching feeds that omit guid by using link as stand-in (#1785)

Fixed
- Fix updated api not returning any item after marking item as read (#1713)
- Fix deprecation warning for strip_tags() on a null value (#1766)
- Fix selected item being set incorrectly when using default ordering or newest first ordering (#1324)
- Fix doubling the height of the content area (#1796)

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug frontend impact Javascript/Frontend code
Projects
None yet
7 participants