Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 19.0.1 requires PHP 7.4 but info.xml still has 7.3 as required #2006

Closed
3 tasks done
ZidaneTribal opened this issue Dec 1, 2022 · 6 comments
Closed
3 tasks done
Labels

Comments

@ZidaneTribal
Copy link

ZidaneTribal commented Dec 1, 2022

IMPORTANT

Read and tick the following checkbox after you have created the issue or place an x inside the brackets ;)

  • I have read the CONTRIBUTING.md and followed the provided tips
  • I accept that the issue will be closed without comment if I do not check here
  • I accept that the issue will be closed without comment if I do not fill out all items in the issue template.

Explain the Problem

Composer error after upgrading News app to latest release 19.0.1
Seems one of the updated dependencies in 19.0.1 requires PHP 7.4.
Please update the info.xml if you meant to upgrade the required PHP version.
(Nextcloud 23 is supposed to still work on PHP 7.3 so I am unsure if this was an expected dependency change or not)

Steps to Reproduce

Explain what you did to encounter the issue

  1. Updated News from 19.0.0 to 19.0.1
  2. Right afterwards Nextcloud was unavailable due to "Your Composer dependencies require a PHP version ">= 7.4.0". You are running 7.3.15"
  3. Only disabling the App and manually redownloading 19.0.0 reviewed the Nextcloud instance

System Information

  • News app version: 19.0.1
  • Nextcloud version: 23.0.11
  • Cron type: system cron
  • PHP version: 7.3.15
  • Database and version: x
  • Browser and version: x
  • OS and version :x

Error not logged in nextcloud.log
Error not in browser console

@Grotax
Copy link
Member

Grotax commented Dec 2, 2022

Hey,

thanks for the report.
I actually missed that change, I pulled the release from the appstore and removed the file from the github release.
So at least not more people should run into this.

We usually move on when we have to though and I think we will do the same here and drop support for php 7.3

@dvzrv
Copy link

dvzrv commented Dec 2, 2022

I actually missed that change, I pulled the release from the appstore and removed the file from the github release.

Please don't do that, as it breaks downstream reproducibility (see https://bugs.archlinux.org/task/76717).
Would releasing a new patch-level version after merging #2008 be enough?

@Grotax
Copy link
Member

Grotax commented Dec 2, 2022

No I don't think that is an option, we would need to rollback the changes of the release.
And we do not want to release such changes as patch level, so it will be major version, since we drop support for php 7.3

I had to pull the archive as Nextcloud caches the AppStore data and would even try to pull it after I remove it from the AppStore

@Grotax
Copy link
Member

Grotax commented Dec 2, 2022

Next release won't support PHP 7.3 anymore.

@Grotax
Copy link
Member

Grotax commented Dec 2, 2022

news.tar.gz

This is the file of that release if someone needs it.

@Grotax
Copy link
Member

Grotax commented Jan 11, 2023

We released Nextcloud 20.0.0 it doesn't support PHP 7.3 anymore.

I would recommend to update to PHP 8.1+ soon.

@Grotax Grotax closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants