Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for PHP 7.3 #2008

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Drop support for PHP 7.3 #2008

merged 1 commit into from
Dec 6, 2022

Conversation

Grotax
Copy link
Member

@Grotax Grotax commented Dec 2, 2022

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@SMillerDev
Copy link
Contributor

Since 7.4 is EOL we could drop that one too I guess.

@anoymouserver
Copy link
Contributor

anoymouserver commented Dec 2, 2022

Since 7.4 is EOL we could drop that one too I guess.

I don't think thats a good idea. Even though PHP 7.4 is officially end-of-life since 4 days ago, it's still supported by NC25 and 26 (as of now). Also it is packaged by the current stable Debian 11 and Debian 12 "Bookworm" is planed around mid-2023 (which then contains PHP 8.1). Forcing admins to use 3rd-party apt repositories for NC News isn't my preferred solution unless we really need it.

@Grotax
Copy link
Member Author

Grotax commented Dec 2, 2022

I agree with @anoymouserver. Let's keep 7.4 for now.

@SMillerDev
Copy link
Contributor

Okay, let's drop it in the next major release then.

@Grotax Grotax merged commit 356c3e1 into master Dec 6, 2022
@delete-merged-branch delete-merged-branch bot deleted the php7.3 branch December 6, 2022 13:49
Grotax added a commit that referenced this pull request Dec 14, 2022
Changed
- Drop support for PHP 7.3 (#2008)
- Dependency updates

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@Grotax Grotax mentioned this pull request Dec 14, 2022
Grotax added a commit that referenced this pull request Dec 15, 2022
Changed
- Drop support for PHP 7.3 (#2008)
- Dependency updates

Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
@anoymouserver anoymouserver mentioned this pull request Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants