fix: do not request favicon for empty base URL #2096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Molenaar <sean@seanmolenaar.eu>
SMillerDev
force-pushed
the
fix/favicon/no_request_for_empty_url
branch
from
f55680c
to
7c8526d
Compare
Grotax
approved these changes
Feb 14, 2023
Grotax
added a commit
that referenced
this pull request
Feb 14, 2023
Changed - Drop support for Nextcloud 23 (#2077 ) - Make the "open" keyboard shortcut work faster (#2080) - Implemented search for articles, results can only link to the feed. (#2075) Fixed - Stop errors from the favicon library over empty values (#2096) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Feb 14, 2023
Changed - Drop support for Nextcloud 23 (#2077 ) - Make the "open" keyboard shortcut work faster (#2080) - Implemented search for articles, results can only link to the feed. (#2075) Fixed - Stop errors from the favicon library over empty values (#2096) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is an alternate solution since I believe the core issue is empty URLs being sent to the favicon library.
Checklist