Update feed only if nextUpdateTime has been reached #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Grotax
force-pushed
the
updater/newlogic
branch
from
7dd001c to
70178af
Compare
Grotax
force-pushed
the
updater/newlogic
branch
2 times, most recently
from
d115ee0 to
2d16949
Compare
Grotax
changed the title
|
I'm currently struggling a bit with this for multiple reasons.
Anyway can someone tell me why the field can end up being null? |
SMillerDev
reviewed
Dec 27, 2024
This comment was marked as outdated.
This comment was marked as outdated.
|
Found the issue who would have thought that the Feed-Service does not use the feed object of the fetcher but has it's own and you need to transfer the value :). Which makes me wonder why it worked sometimes. That must have been a different path in the code that causes the value to be passed through ... |
This comment was marked as outdated.
This comment was marked as outdated.
Grotax
force-pushed
the
updater/newlogic
branch
from
3bee890 to
5fa92b3
Compare
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Grotax
force-pushed
the
updater/newlogic
branch
from
5fa92b3 to
f9bb13f
Compare
SMillerDev
approved these changes
Dec 30, 2024
Grotax
added a commit
that referenced
this pull request
Dec 30, 2024
Changed - API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993) - Change logic to update feed only if the nextUpdateTime has been reached (#2999) - Add setting to disable the usage of nextUpdateTime (#2999) Fixed - `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Merged
Grotax
added a commit
that referenced
this pull request
Dec 30, 2024
Changed - API add new field to Feed that indicates when the next update will be done "nextUpdateTime" (#2993) - Change logic to update feed only if the nextUpdateTime has been reached (#2999) - Add setting to disable the usage of nextUpdateTime (#2999) Fixed - `TypeError: this.$refs.actions.$refs.menuButton is undefined` when tabbing through feeds and folders (#3004) Signed-off-by: Benjamin Brahmer <info@b-brahmer.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the logic of updating/fetching a feed to check for the nextUpdateTime before the the update is executed.
If that time is not reached yet the feed is not updated. This is mainly a advantage for feeds that are updated rarely and will therefore receive less requests. For the nextcloud instance this is also a benefit because feed updates that are likely not needed are skipped, which saves compute time.
The default minimum for an active feed is "in 1 hour" which means it will be updated in hour again.
Also added a setting to disable this, mostly for testing but I can also imagine that in the beginning or for certain use cases people want to disable this.
Builds on top of #2993
Checklist