-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use large corner radius for the Popover component #2566
Use large corner radius for the Popover component #2566
Conversation
Signed-off-by: Quentin Guidée <quentin.guidee@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks much nicer, and I think @marcoambrosini will like this too. :)
@quentinguidee 2 things:
- The whitespace chars/tabs seems off in your edit
- What is the overflow:hidden for?
Without the For the whitespace chars/tabs, I'm not sure to understand Edit : an alternative to the |
@jancborchardt could you please specify what major versions of Nextcloud should have this styling? E.g Calendar support Nextcloud 24 down to Nextcloud 21. If we upgrade to this change then installations of Nextcloud 21 will also see rounded corners for Calendar, but not for Talk. I'll let you judge if this is a breaking design change. |
@marcoambrosini the Talk app only targets one major version of Nextcloud at a time, right? So you wouldn't update Compare https://github.com/nextcloud/spreed/blob/master/appinfo/info.xml#L55 to https://github.com/nextcloud/calendar/blob/main/appinfo/info.xml#L36. |
@ChristophWurst seems fine by me to have this in Calendar too, also for lower. Nextcloud versions. |
This PR tries to takes a further step towards the standardization of border radii. Currently, border radii are not uniform. Among other things, buttons have a very high border-radius, while Popovers are only allowed a 3px border-radius, and lists have none.
In the current state of this PR, here are some examples:
Another example (done with devtools) of what it looks like in-app:
In my opinion, it gives a more modern look to NextCloud.
To improve this PR, we could add some vertical padding, but this is open to discussion.