Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Rich editing #1686

Merged
merged 17 commits into from
Mar 7, 2023
Merged

feat: Rich editing #1686

merged 17 commits into from
Mar 7, 2023

Conversation

AlvaroBrey
Copy link
Member

@AlvaroBrey AlvaroBrey commented Feb 15, 2023

  • Fetch and store direct editing capability
    • Use capability to toggle whether direct editing option is available
  • Fetch remote editing info/URL for notes
  • Open notes with remote editing in webview WIP
    • existing notes
    • new notes
  • Allow changing mode to rich editing from plain edit/preview
  • Allow changing to plain edit from rich edit
  • Error handling

Copied from #1645:

Fixes #1645

@AlvaroBrey AlvaroBrey force-pushed the feat/direct-editing branch 7 times, most recently from dcc6cae to 33cf372 Compare February 16, 2023 13:27
@AlvaroBrey
Copy link
Member Author

AlvaroBrey commented Feb 17, 2023

I've managed to get (existing) notes showing up in a webview with text, but for some reason autosave is not working (I can write in the note but it doesn't get saved to server). @tobiasKaminsky do you have any idea what kind of webview config I might be missing? It works on Files but I can't find the problem it was a server problem

@AlvaroBrey AlvaroBrey force-pushed the feat/direct-editing branch 4 times, most recently from b894347 to 36fde04 Compare February 27, 2023 14:06
@AlvaroBrey AlvaroBrey force-pushed the feat/direct-editing branch 2 times, most recently from 8de4cb1 to 277c95a Compare March 2, 2023 08:27
@AlvaroBrey AlvaroBrey changed the title wip: direct editing Support direct editing for notes Mar 2, 2023
@AlvaroBrey
Copy link
Member Author

@tobiasKaminsky still a couple of things to polish, but this is mostly ready to test/review, if you wanna give it a go

@AlvaroBrey AlvaroBrey force-pushed the feat/direct-editing branch 2 times, most recently from 1bf7cc9 to 59b2f5e Compare March 6, 2023 11:40
@tobiasKaminsky
Copy link
Member

Awesome work!

@AlvaroBrey AlvaroBrey marked this pull request as ready for review March 7, 2023 15:10
…xisting capabilities code

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Required by UX team

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
…ch normal edit instead

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Development only!

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
… direct edit

remote id needs to be set

Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
Signed-off-by: Álvaro Brey <alvaro.brey@nextcloud.com>
@AlvaroBrey AlvaroBrey force-pushed the feat/direct-editing branch from 07890ed to 5e517ff Compare March 7, 2023 15:14
@AlvaroBrey AlvaroBrey changed the title Support direct editing for notes feat: Rich editing Mar 7, 2023
@AlvaroBrey AlvaroBrey enabled auto-merge (squash) March 7, 2023 15:15
@AlvaroBrey AlvaroBrey merged commit 4e096b4 into main Mar 7, 2023
@AlvaroBrey AlvaroBrey deleted the feat/direct-editing branch March 7, 2023 15:20
@AlvaroBrey AlvaroBrey added this to the 4.0.0 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to enriched online text editor
2 participants