Do not read the notification we just inserted

Signed-off-by: Joas Schilling <coding@schilljs.com>
nextcloud · Feb 24, 2022 · 240a5cd · 240a5cd
1 parent 9c45cf5
commit 240a5cd
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/lib/App.php b/lib/App.php
@@ -54,8 +54,7 @@ public function notify(INotification $notification): void {
 		$notificationId = $this->handler->add($notification);
 
 		try {
-			$notificationToPush = $this->handler->getById($notificationId, $notification->getUser());
-			$this->push->pushToDevice($notificationId, $notificationToPush);
+			$this->push->pushToDevice($notificationId, $notification);
 		} catch (NotificationNotFoundException $e) {
 			throw new \InvalidArgumentException('Error while preparing push notification');
 		}

diff --git a/tests/Unit/AppTest.php b/tests/Unit/AppTest.php
@@ -53,30 +53,21 @@ protected function setUp(): void {
 
 	public function dataNotify() {
 		return [
-			[23, 'user1'],
-			[42, 'user2'],
+			[23],
+			[42],
 		];
 	}
 
 	/**
 	 * @dataProvider dataNotify
 	 *
 	 * @param int $id
-	 * @param string $user
 	 */
-	public function testNotify($id, $user) {
-		$this->notification->expects($this->once())
-			->method('getUser')
-			->willReturn($user);
-
+	public function testNotify($id) {
 		$this->handler->expects($this->once())
 			->method('add')
 			->with($this->notification)
 			->willReturn($id);
-		$this->handler->expects($this->once())
-			->method('getById')
-			->with($id, $user)
-			->willReturn($this->notification);
 		$this->push->expects($this->once())
 			->method('pushToDevice')
 			->with($id, $this->notification);