Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always show the dismiss all button #1060

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Aug 23, 2021

Close #605
Signed-off-by: szaimen szaimen@e.mail.de

@szaimen
Copy link
Contributor Author

szaimen commented Aug 23, 2021

/compile amend /

Signed-off-by: szaimen <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/605/always-show-dismiss-all-button branch from 11f5a1e to 2f16b57 Compare August 23, 2021 11:00
@@ -43,6 +43,8 @@
.notification-wrapper {
display: flex;
flex-direction: column;
margin-bottom: 44px;
max-height: calc(100vh - 50px * 4 - 44px) !important;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets hope no one uses a device that is smaller than 244 pixels + 50px of the header

@nickvergessen nickvergessen merged commit 47ae540 into master Aug 23, 2021
@nickvergessen nickvergessen deleted the enh/605/always-show-dismiss-all-button branch August 23, 2021 12:00
@szaimen
Copy link
Contributor Author

szaimen commented Aug 23, 2021

Can we backport this as it is small change but big UX improvement?

@nickvergessen
Copy link
Member

/backport to stable22

@nickvergessen
Copy link
Member

/backport to stable21

@szaimen
Copy link
Contributor Author

szaimen commented Aug 23, 2021

Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"dismiss all notifications" button should always be visible
2 participants