Properly log action failure #498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
approved these changes
Dec 4, 2019
| } | ||
| } catch(error) { | ||
| console.error('Failed to perform action', error) | ||
| OC.Notification.showTemporary(t('notifications', 'Failed to perform action')) |
There was a problem hiding this comment.
Should use the toast instead? @skjnldsv
nickvergessen
approved these changes
Apr 15, 2020
nickvergessen
force-pushed
the
enhancement/debug-actions
branch
from
e22f7d7
to
0e980ed
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
nickvergessen
force-pushed
the
enhancement/debug-actions
branch
from
0e980ed
to
940960f
Compare
|
what is this pr xD |
Merged. It is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com