Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Share notification data across tabs #751

Merged
merged 8 commits into from
Sep 17, 2020
Merged

Share notification data across tabs #751

merged 8 commits into from
Sep 17, 2020

Conversation

nickvergessen
Copy link
Member

Fix #703

@nickvergessen
Also unsubscribe from events and dont shutdown completely when going …
0dcd058 
…offline

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Reuse the notification data across tabs
cac70be 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Force refresh on first load
e01bcc2 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix setInterval call
03e59f9 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
More moment() less deprecated methods
a523e7e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
No spam in production
9df9d35 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Update vue lib
f77a465 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
63ae4f6 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 20 milestone Sep 14, 2020
@rullzer rullzer mentioned this pull request Sep 14, 2020
Merged
5 tasks
rullzer
rullzer approved these changes Sep 15, 2020
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoohoo!
Tested and still works!

@nickvergessen
Copy link
Member Author

So aparently there are still cases where 2 tabs send the browser notification

@rullzer rullzer merged commit 01851f0 into master Sep 17, 2020
@rullzer rullzer deleted the techdebt/703/share-notification-data-across-tabs branch September 17, 2020 06:54
@rullzer
Copy link
Member

rullzer commented Sep 17, 2020

So aparently there are still cases where 2 tabs send the browser notification

Lets tackle that separatly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees
No one assigned
Labels
2. developing technical debt
Projects
None yet
Milestone
Nextcloud 20
Development

Successfully merging this pull request may close these issues.

Multiple systray notifications
3 participants
@nickvergessen @rullzer @skjnldsv