Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n: Improve spelling stylistics #109

Merged
merged 2 commits into from
Jan 7, 2021
Merged

l10n: Improve spelling stylistics #109

merged 2 commits into from
Jan 7, 2021

Conversation

Valdnet
Copy link
Contributor

@Valdnet Valdnet commented Sep 17, 2020

No description provided.

@Valdnet Valdnet requested review from blizzz and rullzer September 28, 2020 10:16
</label>
</p>
<p>
<label class="password-policy-number-option">
<input id="password-policy-history-size" type="number" value="<?php p($_['historySize']) ?>" />
<span><?php p($l->t('User password history')) ?></span>
<span><?php p($l->t('User passwords history')) ?></span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the singular use of "password" is actually correct here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected 😉.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one remark, otherwise 👍

@Valdnet Valdnet requested a review from blizzz January 6, 2021 19:47
@blizzz blizzz merged commit 2d82b81 into master Jan 7, 2021
@blizzz blizzz deleted the Valdnet-patch-1 branch January 7, 2021 10:34
@rullzer rullzer mentioned this pull request Jan 7, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants